Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Lists] - Update exceptions table header and export icon #122870

Merged
merged 2 commits into from
Jan 17, 2022
Merged

[Security Solution][Lists] - Update exceptions table header and export icon #122870

merged 2 commits into from
Jan 17, 2022

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jan 12, 2022 •
edited
Loading

Summary

Addresses #121758 and #121759.

Updates exceptions table export icon to be "download" icon and updates exceptions table header to use native EUI page headers.

Screen Shot 2022-01-12 at 10 42 25 AM

Screen Shot 2022-01-12 at 10 54 45 AM

Checklist

@yctercero yctercero mentioned this pull request Jan 12, 2022
Closed
@yctercero yctercero self-assigned this Jan 12, 2022
@yctercero yctercero added release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team v8.0.0 v8.1.0 and removed v8.0.0 labels Jan 12, 2022
@yctercero yctercero marked this pull request as ready for review January 12, 2022 21:19
@yctercero yctercero requested a review from a team as a code owner January 12, 2022 21:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

spong
spong approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@spong spong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, but may want to confirm changes with design as we have some differences floating around through the app.

Value lists uses this download icon for upload:

And the Rule Table export action has up arrow for export:

Also, the last updated label being in the top right corner, is this new design language we should be adopting over on the rules table and elsewhere as well?

@yctercero
Copy link
Contributor Author

Thanks @spong ! I'll wait to get feedback from UX.

cc: @gavinwye @snide @yiyangliu9286

@gavinwye
Copy link

Thanks, @spong I've checked the icons in EUI. We seem to have some very similar icons, I'm not sure users would see the difference it took me a while to see the differences.

But, I think the icons we have at least now are being used as specified in EUI.

Screenshot 2022-01-14 at 14 39 21

Screenshot 2022-01-14 at 14 40 46

Screenshot 2022-01-14 at 14 43 54

To that end, I think we can merge this PR @yctercero

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +85.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 8c0fbdf into elastic:main Jan 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 17, 2022
@yctercero yctercero mentioned this pull request Jan 17, 2022
Closed
@yctercero yctercero mentioned this pull request Jan 26, 2022
Merged
yctercero added a commit to yctercero/kibana that referenced this pull request Jan 26, 2022
@yctercero
update exceptions table header and export icon (elastic#122870)
47e1d61 
Addresses elastic#121758 and elastic#121759.

Updates exceptions table export icon to be "download" icon and updates exceptions table header to use native EUI page headers.

(cherry picked from commit 8c0fbdf)
yctercero added a commit that referenced this pull request Jan 26, 2022
@yctercero @kibanamachine
update exceptions table header and export icon (#122870) (#123787)
8c9e96e 
Addresses #121758 and #121759.

Updates exceptions table export icon to be "download" icon and updates exceptions table header to use native EUI page headers.

(cherry picked from commit 8c0fbdf)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@yctercero yctercero deleted the exceptions_minor_ux_fixes branch August 4, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@yctercero yctercero

Labels
backport:skip This commit does not require backporting release_note:fix Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yctercero @elasticmachine @gavinwye @kibana-ci @spong @kibanamachine