Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] fix Label border color is not removed from legend when disabled #122705

Merged
merged 1 commit into from
Jan 11, 2022
Merged

[maps] fix Label border color is not removed from legend when disabled #122705

merged 1 commit into from
Jan 11, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 11, 2022

Fixes #122656

This PR resolves the issue by filtering out label style properties from the legend when label is not set.

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This commit does not require backporting v8.1.0 labels Jan 11, 2022
@nreese nreese requested a review from a team as a code owner January 11, 2022 20:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +138.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese added v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Jan 11, 2022
thomasneirynck
thomasneirynck approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, verified this works in chrome

x-pack/plugins/maps/public/classes/styles/vector/style_util.ts Show resolved Hide resolved
@nreese nreese merged commit a5a5db4 into elastic:main Jan 11, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 11, 2022
@nreese @kibanamachine
[maps] fix Label border color is not removed from legend when disabled (
4fa8c40 
elastic#122705)

(cherry picked from commit a5a5db4)
@kibanamachine kibanamachine mentioned this pull request Jan 11, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 12, 2022
@kibanamachine @nreese
[maps] fix Label border color is not removed from legend when disabled (
e6bd9f1 
#122705) (#122724)

(cherry picked from commit a5a5db4)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Label border color is not removed from legend when disabled
5 participants
@nreese @elasticmachine @kibana-ci @kibanamachine @thomasneirynck