Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip remaining Cypress tests from RAC rules migration #122661

Merged
merged 9 commits into from
Jan 13, 2022
Merged

[Security Solution] Unskip remaining Cypress tests from RAC rules migration #122661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7bef661
Unskip indicator match timeline test
madirey Nov 30, 2021
65978da
Unskip fields_browser tests
madirey Nov 30, 2021
05d549e
Enable alert_summary tests
madirey Dec 2, 2021
20b6ed6
add cti feed enrichment
madirey Jan 4, 2022
0f1013e
Fix accessibility text in indicator match cypress test
madirey Jan 10, 2022
3cd4944
Adjust fields_browser test to account for removed field
madirey Jan 10, 2022
e7e67cb
Correct indicator_match row renderer text in cypress test
madirey Jan 11, 2022
4848c3d
Merge branch 'main' of github.com:elastic/kibana into unskip-rac-cypress
madirey Jan 11, 2022
b3847fb
Revert "Enable alert_summary tests"
madirey Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...lugins/security_solution/cypress/integration/detection_rules/indicator_match_rule.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ describe('indicator match', () => {
cy.get(ALERT_RISK_SCORE).first().should('have.text', getNewThreatIndicatorRule().riskScore);
});

it.skip('Investigate alert in timeline', () => {
it('Investigate alert in timeline', () => {
const accessibilityText = `Press enter for options, or press space to begin dragging.`;

loadPrepackagedTimelineTemplates();
Expand Down Expand Up @@ -540,7 +540,8 @@ describe('indicator match', () => {
getNewThreatIndicatorRule().indicatorMappingField
}${accessibilityText}matched${getNewThreatIndicatorRule().indicatorMappingField}${
getNewThreatIndicatorRule().atomic
}${accessibilityText}threat.enrichments.matched.typeindicator_match_rule${accessibilityText}`
}${accessibilityText}threat.enrichments.matched.typeindicator_match_rule${accessibilityText}provided` +
` byfeed.nameAbuseCH malware${accessibilityText}`
);
});
});
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/cypress/integration/timelines/fields_browser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,12 @@ describe('Fields Browser', () => {
});
});

it.skip('displays a count of only the fields in the selected category that match the filter input', () => {
it('displays a count of only the fields in the selected category that match the filter input', () => {
const filterInput = 'host.geo.c';

filterFieldsBrowser(filterInput);

cy.get(FIELDS_BROWSER_SELECTED_CATEGORY_COUNT).should('have.text', '5');
cy.get(FIELDS_BROWSER_SELECTED_CATEGORY_COUNT).should('have.text', '4');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madirey this change is not correct, we are still having 5 fields, this test was catching a legitimate bug.

The problem here is that when we are opening the timeline the new alert's index is not selected by default when it should, that index is the one that contains the missing field.

We should fix the issue and change the number of the test to 5 again, I'll open a ticket with the bug and assign to the alerts team since I'm assuming that as the issue was introduced when the rule registry changes were merged is the alerts team the one that should take care of it. Please note that this change impacts one of new explore team functionalities.

ping @spong @rylnd @stephmilovic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadameSheema I only see 4 fields in the ECS field mapping. Is there an additional non-ECS one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.elastic.co/guide/en/ecs/current/ecs-geo.html

As you can see, the test is looking at geo fields that start with c. there are 5

You are only looking at ecs mapping for Data View before it has alerts mappings because alerts index has not been initialized yet. Alerts index has extra field, if i recall correctly geo.continent_code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephmilovic @MadameSheema The new alerts mapping doesn't contain the geo.continent_code field so I believe it will only show up on upgrades (since the field exists in the legacy .siem-signals index, which is aliased). New installs will have only 4 fields. Our team will be updating the ECS mappings soon, which should result in that field being added. We should be able to update the test at that point.

});
});

Expand Down