Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v44.0.0 #122386

Merged
merged 6 commits into from
Jan 11, 2022
Merged

Upgrade EUI to v44.0.0 #122386

merged 6 commits into from
Jan 11, 2022

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Jan 5, 2022

Summary

eui@43.1.1eui@44.0.0

44.0.0

Bug fixes

  • Fixed a EuiDataGrid sizing bug which didn't account for a horizontal scrollbar (#5478)
  • Fixed a EuiDatePicker a11y bug where axe-core reported missing ARIA and role attributes (#5501)
  • Fixed EuiModalHeaderTitle to conditionally wrap title strings in an H1 (#5494)
  • Fixed a EuiDataGrid issue where a focused cell would lose focus when scrolled out of and back into view (#5488)
  • Fixed an EuiDatePicker accessibility issue where tabindex was not applied to a listbox element (#5509)

Deprecations

  • Deprecated PartitionConfig in favor of inclusion in Charts theme.partition (#5492)

Breaking changes

  • Removed popoverClassName and repositionOnScroll props from EuiSuperSelect (use popoverProps instead) (#5512)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Jan 5, 2022
@cee-chen cee-chen requested review from a team as code owners January 5, 2022 20:16
@cee-chen cee-chen requested a review from a team January 5, 2022 20:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@cee-chen cee-chen marked this pull request as draft January 5, 2022 20:17
@cee-chen cee-chen removed the v8.2.0 label Jan 5, 2022
@chandlerprall
Copy link
Contributor

cc @nickofthyme

@cee-chen
Copy link
Member Author

cee-chen commented Jan 6, 2022

I'll look into the security failures tomorrow. @thompsongl heads up that the kbnUiSharedDeps-npmDll size didn't end up going down from 6.1MB to the 5.1MB that it was in #120935 😖

@thompsongl
Copy link
Contributor

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@cee-chen
Copy link
Member Author

@elastic/security-solution, @elastic/workplace-search-frontend - would y'all mind reviewing the appropriate source changes in your respective touched files? Thank you!

Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janmonschke
Copy link
Contributor

I noticed a rendering issue on the alert table within the security solution:
Screenshot 2022-01-10 at 18 22 27

There is extra white-space below the last element in the table. This is caused by the "height-hack" that was introduced in #109269.

Removing that height-hack fixes the issue. I don't think the removal needs to be part of this PR though, I will make sure to remove that hack in a follow-up PR.

@cee-chen
Copy link
Member Author

Thanks @janmonschke! Just to clarify, did you notice this on latest main or specifically on this branch? If on latest main, that was a fix that likely was in the previous EUI upgrade, and you should be able to open a PR whenever. Super appreciate y'all taking care of it either way!

@janmonschke
Copy link
Contributor

@constancecchen I first noticed it on the latest main and then saw this PR that has another fix for the data grid which fixes all the issues we were trying to solve with the height hack. Will create a PR after this one made it into main :)

@cee-chen
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team January 10, 2022 23:10
@cee-chen
Copy link
Member Author

@elastic/security-solution - heads up I'll be merging this with or without approval in a few hours. Changes were relatively straightforward, but would appreciate your eyes on this if you have time (or after merge, however timing shakes out).

@cee-chen
Copy link
Member Author

@elasticmachine merge upstream

@cee-chen cee-chen enabled auto-merge (squash) January 11, 2022 17:26
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +8.0B
securitySolution 4.6MB 4.6MB +39.0B
total +47.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.1MB 6.1MB -49.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen enabled auto-merge (squash) January 11, 2022 19:31
@cee-chen cee-chen merged commit 7ec1606 into elastic:main Jan 11, 2022
@cee-chen cee-chen deleted the eui-44.0.0 branch January 11, 2022 19:31
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 11, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 122386

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants