-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Significant Text agg to AggConfigs #122166
Conversation
* Significant text is available only for ES_FIELD_TYPES.TEXT, | ||
* This information is not available from field.type, so we have to check this using underlying esTypes | ||
*/ | ||
filterField: (field) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Significant text aggregation only allows fields of types TEXT,
for this had to add a new way to filter supported fields for an aggregation.
With this we will also be able to allow integer fields for significant terms as mentioned here: #40368 (comment)
@elasticmachine merge upstream |
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VisEditors changes LGTM, thanks for adding this. I will bring this topic up with the team, I agree that this is a helpful feature and should be exposed.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
close #67394
This adds significant text aggregation to agg configs and expressions.
This aggregation is similar to significant terms but works only on fields of type TEXT. It also doesn't support child aggregations.
Agg docs
For now, I excluded this agg in visualize editor (everywhere where we excluded
multi_terms
), but we can consider enabling it, as it gives some user-facing value. For example, we can retrive significant terms from TEXT fields for tag cloud:But since this agg doesn't support child aggregations it only works for the
COUNT
metric. If a user changescount
to something else, then there is an error. So I suppose that more works needs to be done in visualize editor before we can enable those.