Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add model_prune_window to job summary API expected response #121777

Merged
merged 1 commit into from
Dec 21, 2021
Merged

[ML] Add model_prune_window to job summary API expected response #121777

merged 1 commit into from
Dec 21, 2021

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Dec 21, 2021 •
edited
Loading

Summary

For new anomaly detection jobs, when the analysis config field model_prune_window is not set, a default value of 30 days is now supplied - see elastic/elasticsearch#81377.

This corrects the expected response for the jobs_summary API integration test to include the default model_prune_window of 30d

Checklist

Fixes #121686

@peteharverson peteharverson added review :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes test-api-integration backport:skip This commit does not require backporting v8.1.0 labels Dec 21, 2021
@peteharverson peteharverson requested a review from a team as a code owner December 21, 2021 15:04
@peteharverson peteharverson self-assigned this Dec 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Dec 21, 2021

LGTM 🎉

droberts195
droberts195 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@peteharverson peteharverson merged commit 31aef42 into elastic:main Dec 21, 2021
@peteharverson peteharverson deleted the ml-fix-job-summmary-test branch December 21, 2021 16:26
@pheyos pheyos mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

@qn895 qn895 qn895 approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@peteharverson peteharverson

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes review test-api-integration v8.1.0
Projects
None yet
Milestone
No milestone
5 participants
@peteharverson @elasticmachine @qn895 @kibana-ci @droberts195