use PIT search for savedObjectTagging plugin #120476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Feature:Saved Object Tagging
pgayvallet
commented
Dec 6, 2021
Comment on lines
+53
to
+58
| httpCode: 403, | ||
| expectResponse: ({ body }) => { | ||
| expect(body).to.eql({ | ||
| tags: [], | ||
| error: 'Forbidden', | ||
| message: 'unauthorized', | ||
| statusCode: 403, |
There was a problem hiding this comment.
openPointInTimeForType throws with a 403 when the user don't have the permissions to access any of the searched types, where find returns an empty list instead (which is more consistent with how most of the other SO apis behave). see #109062 (comment) for more context
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
Dec 7, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* use PIT search for savedObjectTagging plugin * fixing FTR tests * foo is the new grep * fix tests * fix tests again
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* use PIT search for savedObjectTagging plugin * fixing FTR tests * foo is the new grep * fix tests * fix tests again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #93770
Use
PITbased searches instead of usingperPage: 10kfor SOT plugin