Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Added KibanaThemeProvider. #120122

Merged
merged 10 commits into from
Dec 7, 2021
Merged

[Dashboard] Added KibanaThemeProvider. #120122

merged 10 commits into from
Dec 7, 2021

Conversation

Kuznietsov
Copy link
Contributor

Summary

Preformed required changes at the issue #118866

Added KibanaThemeProvider to the Dashboard plugin in all places, where ReactDOM.render is executed.

@Kuznietsov Kuznietsov self-assigned this Dec 1, 2021
@Kuznietsov Kuznietsov marked this pull request as ready for review December 2, 2021 09:07
@Kuznietsov Kuznietsov requested a review from a team as a code owner December 2, 2021 09:07
@Kuznietsov Kuznietsov added backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0 labels Dec 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Kuznietsov Kuznietsov mentioned this pull request Dec 2, 2021
Closed
@Kuznietsov Kuznietsov added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Dec 2, 2021
ThomThomson
ThomThomson reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! All the changes here make sense, but I believe there are a few more places that Modals or flyouts are used where the kibanaTheme might need to be propagated.

Check in

src/plugins/dashboard/public/application/actions/library_notification_action.tsx
src/plugins/dashboard/public/application/actions/copy_to_dashboard_action.tsx
src/plugins/dashboard/public/application/actions/open_replace_panel_flyout.tsx

Also, we don't need to cover these in this PR, because they aren't technically part of dashboard, but there are a few places in the embeddables plugin where I know a flyout or modal is opened.

src/plugins/embeddable/public/lib/panel/panel_header/panel_actions/add_panel/open_add_panel_flyout.tsx
src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@ThomThomson, could you, please, review current PR again? Thanks a lot)

ThomThomson
ThomThomson approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Thanks for covering those areas that I mentioned before, and nice find with the confirm modals from the listing page! I can't think of any other areas this PR misses, but if we find any, we can always do a follow-up!

Thanks for doing this @Kunzetsov \

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov enabled auto-merge (squash) December 7, 2021 07:02
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 274.6KB 274.9KB +339.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 64.7KB 65.1KB +427.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov merged commit f45df48 into elastic:main Dec 7, 2021
@Kuznietsov
Copy link
Contributor Author

@ThomThomson, thanks for your review)

jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 7, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/close…
364ffac 
…-chromium-before-compiling-pdf

* 'main' of github.com:elastic/kibana: (121 commits)
  FTR should use the new kibana_system user (elastic#120436)
  [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list (elastic#120488)
  [Reporting] Fix slow CSV with large max size bytes (elastic#120365)
  [CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations -  (elastic#120459)
  [Dashboard] Added KibanaThemeProvider.  (elastic#120122)
  add more rule_registry unit tests (elastic#120323)
  [Lens] update xpack.lens.pie.smallValuesWarningMessage text (elastic#120478)
  [Fleet] Simplified package policy create API, enriching default values (elastic#119739)
  mock `elastic-apm-node` in `@kbn/test` jest preset (elastic#120324)
  [RAC] Rename occurrences of alert_type to rule_type in Infra (elastic#120455)
  [Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (elastic#120437)
  [Workplace Search] Add API Keys view to replace Access tokens (elastic#120147)
  [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the server section (elastic#120411)
  Add support for threat.feed.name (elastic#120250)
  [Rule Registry] Rewrite APM registry rules for Observability (elastic#117740)
  [docs] Fix artifact layout formatting (elastic#119386)
  [Workplace Search] Add a technical preview of connecting GitHub via GitHub apps (elastic#119764)
  add osquery notes for 7.16 (elastic#120407)
  chore(NA): splits types from code on @kbn/docs-utils (elastic#120533)
  [Reporting] Decouple screenshotting plugin from the reporting (elastic#120110)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.test.ts
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/test_helpers/create_mock_browserdriverfactory.ts
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@Kuznietsov @kibanamachine @TinLe
[Dashboard] Added KibanaThemeProvider. (elastic#120122)
6a89665 
* Integrated kibanaThemeProvider to dashboard main app.

* Added kibanaThemeProvider to dashboard container.

* Added KibanaThemeProvider to placeholder_embeddable.

* Added KibanaThemeProvider to showCloneModal.

* Added kibanaThemeProvider to show_options_popover.

* Added theme$ to Dashboard flyouts and modals.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@crob611 crob611 Awaiting requested review from crob611

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kuznietsov @elasticmachine @kibana-ci @ThomThomson @kibanamachine