Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Added KibanaThemeProvider to expression_image. #120104

Merged
merged 16 commits into from
Dec 6, 2021
Merged

[Canvas] Added KibanaThemeProvider to expression_image. #120104

merged 16 commits into from
Dec 6, 2021

Conversation

Kuznietsov
Copy link
Contributor

Summary

Performed required changes at the issue #120071.

Added KibanaThemeProvider to the expression_image plugin in all places, where ReactDOM.render is executed.

Kuznietsov and others added 15 commits November 25, 2021 17:33
@Kuznietsov
Added KibanaThemeProvider to canvas application.
1eec03f
@Kuznietsov
Added KibanaThemeProvider to embeddable.
93e8398
@Kuznietsov
Added KibanaThemeProvider to filters.
c4fab44
@Kuznietsov
Added ThemeProvider to all other places of Canvas.
5092096
@Kuznietsov
Fixed shareable.
38095b5
@kibanamachine
Merge branch 'main' into canvas-kibana-theme-provider
5bc0169
@Kuznietsov
Added coreStartMock to canvas.
84a055d
@Kuznietsov
Refactored supported_renderers to handle renderers, which requires th…
e65f51a 
…emes.
@kibanamachine
Merge branch 'main' into canvas-kibana-theme-provider
f1f8963
@kibanamachine
Merge branch 'main' into canvas-kibana-theme-provider
781847a
@Kuznietsov
Renamed get_FN to get_Renderer.
d2ebf50
@Kuznietsov
Wrapped up debug and error with KibanaThemeProvider.
062a6b0 
1. Replaced renderer with getRenderer function and factory.
2. Updated storybook.
3. Moved defaultTheme$ to presentain_util.
@Kuznietsov
Merge branch 'main' into expression-error-kibana-theme-provider
c4da2b0 
# Conflicts:
#	x-pack/plugins/canvas/canvas_plugin_src/renderers/markdown/index.tsx
#	x-pack/plugins/canvas/canvas_plugin_src/renderers/table.tsx
#	x-pack/plugins/canvas/canvas_plugin_src/renderers/text.tsx
#	x-pack/plugins/canvas/shareable_runtime/supported_renderers.js
@Kuznietsov
Fixed exports.
3d1dc4c
@Kuznietsov
Added kibanaThemeProvider to expression_image
ea5199d
@Kuznietsov Kuznietsov added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This commit does not require backporting Feature:Canvas v8.1.0 labels Dec 1, 2021
@Kuznietsov Kuznietsov self-assigned this Dec 1, 2021
@Kuznietsov Kuznietsov requested a review from a team as a code owner December 1, 2021 14:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Kuznietsov Kuznietsov mentioned this pull request Dec 1, 2021
Closed
7 tasks
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionImage 24 26 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1013.2KB 1013.2KB -1.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionImage 4.2KB 4.5KB +251.0B
Unknown metric groups

API count

id before after diff
expressionImage 24 26 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov merged commit d4ff3fc into elastic:main Dec 6, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@Kuznietsov @kibanamachine @TinLe
[Canvas] Added KibanaThemeProvider to expression_image. (elastic#120104)
ac46d6e 
* Added kibanaThemeProvider to expression_image

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@Kuznietsov @kibanamachine @gbamparop
[Canvas] Added KibanaThemeProvider to expression_image. (elastic#120104)
7ceb3c2 
* Added kibanaThemeProvider to expression_image

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kuznietsov @elasticmachine @kibanamachine @kibana-ci @crob611