[Canvas] Added KibanaThemeProvider to expression_shape. #120099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replaced renderer with getRenderer function and factory. 2. Updated storybook. 3. Moved defaultTheme$ to presentain_util.
# Conflicts: # x-pack/plugins/canvas/canvas_plugin_src/renderers/markdown/index.tsx # x-pack/plugins/canvas/canvas_plugin_src/renderers/table.tsx # x-pack/plugins/canvas/canvas_plugin_src/renderers/text.tsx # x-pack/plugins/canvas/shareable_runtime/supported_renderers.js
Kuznietsov
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Kuznietsov
changed the title
7 tasks
|
@elasticmachine merge upstream |
crob611
reviewed
Dec 2, 2021
| export * from './expression_functions'; | ||
| export * from './expression_renderers'; | ||
|
|
||
| export type { |
There was a problem hiding this comment.
I think it's fine to do export * in places as long as it's not a root index file. No need to change anything, just a heads up
crob611
approved these changes
Dec 2, 2021
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* Added kibanaThemeProvider to expression_shape. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* Added kibanaThemeProvider to expression_shape. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performed required changes at the issue #120071.
Added KibanaThemeProvider to the
expression_repeat_imageplugin in all places, whereReactDOM.renderis executed.