Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip remaining Cypress tests from RAC rules migration #119997

Closed
wants to merge 57 commits into from

Conversation

madirey
Copy link
Contributor

@madirey madirey commented Nov 30, 2021

Summary

This PR unskips the remaining timeline-related Cypress tests that were skipped as part of the RAC rules migration.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@madirey madirey added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 30, 2021
@madirey madirey requested a review from a team as a code owner November 30, 2021 17:44
@madirey madirey added Feature:Detection Alerts Security Solution Detection Alerts Feature Feature:RAC label obsolete Theme: rac label obsolete CTI area Team:Threat Hunting Security Solution Threat Hunting Team labels Dec 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@MadameSheema
Copy link
Member

@elasticmachine merge upstream

@madirey madirey self-assigned this Dec 3, 2021
@madirey madirey added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team labels Dec 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@madirey madirey added the Team:Detections and Resp Security Detection Response Team label Dec 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@madirey madirey changed the title [Security Solution] Unskip more tests [Security Solution] Unskip remaining Cypress tests from RAC rules migration Dec 3, 2021
@madirey madirey mentioned this pull request Dec 3, 2021
20 tasks
@madirey
Copy link
Contributor Author

madirey commented Dec 6, 2021

@elasticmachine merge upstream

@MadameSheema
Copy link
Member

I have investigated why the above tests are failing and the reason is the same in both cases.

Screenshot 2021-12-17 at 12 12 52

.alerts-security.alerts-default index not present by default in the data view.

@stephmilovic
Copy link
Contributor

@madirey can you see if you open the dropdown if its there? i bet its there just disabled. i believe it is defined, but not initialized. there needs to be data pushed to it

@madirey madirey requested a review from a team as a code owner January 4, 2022 21:58
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 244.7KB 245.2KB +591.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @madirey

@madirey madirey closed this Jan 11, 2022
@madirey
Copy link
Contributor Author

madirey commented Jan 11, 2022

Closed in favor of #122661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CTI area Feature:Detection Alerts Security Solution Detection Alerts Feature Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants