Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Close expanded document sidebar when switch data views #119736

Merged
merged 8 commits into from
Dec 2, 2021
Merged

[Discover] Close expanded document sidebar when switch data views #119736

merged 8 commits into from
Dec 2, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Nov 25, 2021 •
edited
Loading

Summary

Closes #119580

Current PR closes sidebar when switch data views.

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Nov 25, 2021
@dimaanj dimaanj self-assigned this Nov 25, 2021
@dimaanj
Copy link
Contributor Author

dimaanj commented Nov 30, 2021

@elasticmachine merge upstream

@dimaanj dimaanj marked this pull request as ready for review November 30, 2021 13:13
@dimaanj dimaanj requested a review from a team as a code owner November 30, 2021 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Dec 1, 2021

@elasticmachine merge upstream

@kertal kertal self-requested a review December 1, 2021 10:03
kertal
kertal approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested a-la-carte using Chrome and Firefox, works as expected 👍

  • Left one minor note about types that could be improved
  • Think this PR should be classified a fix

@dimaanj dimaanj added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 1, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 312.2KB 312.3KB +107.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@kertal
Copy link
Member

kertal commented Dec 2, 2021

thx for those adaptations!

@dimaanj dimaanj merged commit 4107d40 into elastic:main Dec 2, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 2, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@dimaanj @kibanamachine @TinLe
[Discover] Close expanded document sidebar when switch data views (el…
8d483cd 
…astic#119736)

* [Discover] close expanded document sidebar on index pattern change

* [Discover] fix unit test

* [Discover] fix use_discover_state unit test

* [Discover] fix linting

* [Discover] apply suggestions

* [Discover] fix linting

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@dimaanj dimaanj

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Close document flyout when data view is switched
5 participants
@dimaanj @elasticmachine @kertal @kibana-ci @kibanamachine