Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix renovate config [skip-ci] #118713

Merged
merged 1 commit into from
Nov 16, 2021
Merged

fix renovate config [skip-ci] #118713

merged 1 commit into from
Nov 16, 2021

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Nov 16, 2021 •
edited
Loading

Summary

A comma was accidentally forgotten when a new grouping was added causing a silent failure. I updated a few other things per a conversation with renovate dev (renovatebot/renovate#11412), namely:

  • Un-nest the packageRules, apparently this can cause issues
  • Convert .json5 file to .json for $schema validation and louder yelling for missing commas
  • Update keys to latest config options
  • Add comma before final group 😉

Otherwise config is unchanged

@nickofthyme nickofthyme requested a review from spalger November 16, 2021 15:40
@nickofthyme nickofthyme added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci labels Nov 16, 2021
@nickofthyme nickofthyme changed the title fix renovate config fix renovate config [skip-ci] Nov 16, 2021
spalger
spalger approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickofthyme

@nickofthyme nickofthyme enabled auto-merge (squash) November 16, 2021 16:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit 597e76d into elastic:main Nov 16, 2021
@nickofthyme nickofthyme deleted the fix-renovate-config branch November 16, 2021 17:11
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@nickofthyme @dmlemeshko
fix renovate config (#118713)
8280cf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickofthyme @kibana-ci @spalger