Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Added step duraion in step list #116266

Merged
merged 22 commits into from
Dec 6, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 26, 2021

Summary

Fixes elastic/uptime#392

Added a step duraiton in the step list and trend chart and deep link to exploratory view for further exploration.

Updated screenshot with updated units

image

Won't display for skipped step
image

image

Will not show any step duration for fixed steps.

Shows trend chart for last 48 checks last values.

Added functional tests as well using @elastic/synthetics .

@drewpost
Copy link

I'm a sucker for these super useful "little" additions. I'd be happy to see that ship in the product.

@drewpost
Copy link

@shahzad31 a couple of little things.

  • Can we change the units from MS into seconds in a SS.s format?
  • What happens if a step doesn't run or fails? Do we still show a chart? ie if a step didn't run then there's no value for duration in that view. What's displayed and can I still get to the chart for the history of that step?
  • This might be a bit more challenging but is there a way to distinguish between good test runs that passed for that step and ones that failed with some sort of colour or indicator?
  • Just to double check - the results are individual test runs and not aggregated buckets of time, right?
    cc @liciavale

@shahzad31
Copy link
Contributor Author

Ignore skipped step duration
image

@shahzad31 shahzad31 marked this pull request as ready for review November 30, 2021 13:48
@shahzad31 shahzad31 requested a review from a team as a code owner November 30, 2021 13:48
@elastic elastic deleted a comment from kibanamachine Nov 30, 2021
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks great! Had a few comments/questions I wanted to address, but this is really close.

@paulb-elastic
Copy link
Contributor

This should probably use metrics consistent with the overview history page (seconds), or at least show in seconds with a decimal to millisecond precision (current implementation of microseconds is probably too detailed)
image

@shahzad31
Copy link
Contributor Author

@paulb-elastic it's already converted to seconds, i will update the screenshot in the description.

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good. Had a few remarks on the functionality, illustrated by the GIF:

20211201105828

Two main points:

  1. We might need to re-evaluate the way these lists are handling the open state for these popovers. We should probably only have one of these open at a given time.
  2. I think it's better if we drop the second significant digit for the duration metric, and just display the number of seconds as an integer. I'm thinking there might be a bug where we are losing precision since all of these real-world steps are reading as x.0.

@shahzad31
Copy link
Contributor Author

@justinkambic fixed the decimal point issue and also it will only show one popover now

image

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some weirdness happening based on the step name (I think):

image

Not sure if there's some kind of escaping we need to do before sending the data to lens.

Other than that this is looking good. I did find a few UI glitches but they seem to be happening on main, so unrelated.

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 644 646 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 362.2KB 362.3KB +84.0B
uptime 599.5KB 600.8KB +1.3KB
total +1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewpost
Copy link

drewpost commented Dec 6, 2021

Looks good to me! LGTM

@shahzad31 shahzad31 merged commit 27d0b90 into elastic:main Dec 6, 2021
@shahzad31 shahzad31 deleted the step-list-duration branch December 6, 2021 12:40
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 8, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116266 or prevent reminders by adding the backport:skip label.

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 8, 2021
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 8, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Step Lists Page] Adds step duration for each step in steps list
7 participants