-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Added step duraion in step list #116266
Conversation
I'm a sucker for these super useful "little" additions. I'd be happy to see that ship in the product. |
@shahzad31 a couple of little things.
|
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks great! Had a few comments/questions I wanted to address, but this is really close.
x-pack/plugins/uptime/public/components/synthetics/check_steps/step_duration.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/synthetics/check_steps/waterfall_marker_trend.tsx
Outdated
Show resolved
Hide resolved
@paulb-elastic it's already converted to seconds, i will update the screenshot in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking good. Had a few remarks on the functionality, illustrated by the GIF:
Two main points:
- We might need to re-evaluate the way these lists are handling the
open
state for these popovers. We should probably only have one of these open at a given time. - I think it's better if we drop the second significant digit for the duration metric, and just display the number of seconds as an integer. I'm thinking there might be a bug where we are losing precision since all of these real-world steps are reading as
x.0
.
@justinkambic fixed the decimal point issue and also it will only show one popover now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Looks good to me! LGTM |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Fixes elastic/uptime#392
Added a step duraiton in the step list and trend chart and deep link to exploratory view for further exploration.
Updated screenshot with updated units
Won't display for skipped step
Will not show any step duration for fixed steps.
Shows trend chart for last 48 checks last values.
Added functional tests as well using @elastic/synthetics .