Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Auto height setting for table #116156

Merged
merged 13 commits into from
Nov 12, 2021
Merged

[Lens] Auto height setting for table #116156

merged 13 commits into from
Nov 12, 2021

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Oct 25, 2021 •
edited
Loading

Closes: #115582

Summary

Adds tooltip with new setting: Fit row to content which allow user to enable functionality in datagrid with auto-height.
image

Also now in saved object I save the state of this setting as property fitRowToContent

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa VladLasitsa added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0 Feature:Lens labels Nov 4, 2021
@VladLasitsa VladLasitsa marked this pull request as ready for review November 4, 2021 12:37
@VladLasitsa VladLasitsa requested a review from a team as a code owner November 4, 2021 12:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa VladLasitsa self-assigned this Nov 5, 2021
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

dej611
dej611 reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

Left few nitpick comments. Will check locally.

x-pack/plugins/lens/public/datatable_visualization/components/toolbar.tsx Outdated Show resolved Hide resolved
x-pack/plugins/lens/public/datatable_visualization/components/cell_value.tsx Outdated Show resolved Hide resolved
dej611
dej611 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Safari 👍
Will approve to avoid to block it.

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 682 683 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 236 237 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 954.5KB 955.6KB +1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 43.2KB 43.2KB +44.0B
Unknown metric groups

API count

id before after diff
lens 254 255 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa added the backport:skip This commit does not require backporting label Nov 11, 2021
@VladLasitsa VladLasitsa merged commit 64e0aaf into elastic:main Nov 12, 2021
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
@VladLasitsa @kibanamachine @fkanout
[Lens] Auto height setting for table (elastic#116156)
2ab505a 
* Add setting which allow user to fit row to content

* Fix lint

* Change icon

* Fix switch behavior

* Fix some nits

* Fix comments

* Fix lint

* Fix lint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@VladLasitsa @kibanamachine @dmlemeshko
[Lens] Auto height setting for table (#116156)
563ed7a 
* Add setting which allow user to fit row to content

* Fix lint

* Change icon

* Fix switch behavior

* Fix some nits

* Fix comments

* Fix lint

* Fix lint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
@VladLasitsa @kibanamachine
[Lens] Auto height setting for table (elastic#116156)
9b77fdb 
* Add setting which allow user to fit row to content

* Fix lint

* Change icon

* Fix switch behavior

* Fix some nits

* Fix comments

* Fix lint

* Fix lint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

@alexwizp alexwizp alexwizp approved these changes

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees

@VladLasitsa VladLasitsa

Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Auto height setting for table
5 participants
@VladLasitsa @elasticmachine @kibanamachine @dej611 @alexwizp