Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SavedObjects] Adds FTR test for identifying failed validation when supporting attribute re-writing for sort #116028

Closed
wants to merge 2 commits into from

Conversation

spong
Copy link
Member

@spong spong commented Oct 22, 2021

Summary

This is a follow-up to #114585 that adds an FTR test for exercising a nested agg specifying a sort field from the root object as requested here.

See this issue for more details: #115153.

Please let me know if I misunderstood the requested test scenario here, and/or if a specific validation unit-test would be helpful here as well -- thanks! 🙂

Checklist

Delete any items that are not applicable to this PR.

@spong spong added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing v7.16.0 labels Oct 22, 2021
@spong spong requested a review from pgayvallet October 22, 2021 00:29
@spong spong self-assigned this Oct 22, 2021
@spong spong requested a review from a team as a code owner October 22, 2021 00:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@spong spong enabled auto-merge (squash) October 22, 2021 00:33
@spong spong added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 22, 2021
@banderror
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@pgayvallet
Copy link
Contributor

Sorry if I wasn't clear. In https://github.com/elastic/kibana/pull/114585/files#r729620927 I was just asking that your feature using top_hits.sort was properly covered by FTR/integration tests so we detect a potential failure when we'll perform the path rewriting by addressing #115153

@spong
Copy link
Member Author

spong commented Nov 9, 2021

Sorry if I wasn't clear. In https://github.com/elastic/kibana/pull/114585/files#r729620927 I was just asking that your feature using top_hits.sort was properly covered by FTR/integration tests so we detect a potential failure when we'll perform the path rewriting by addressing #115153

Thanks for the clarification! In that case we're good here 🙂 -- I've verified we've got existing FTR/integration tests (find_statues/find_rules) that will fail once #115153 is resolved, so going to go ahead and close out this PR. I also added a note here as the to necessary changes within security security, and will comment on the issue as well. Thanks @pgayvallet!

@spong spong closed this Nov 9, 2021
auto-merge was automatically disabled November 9, 2021 01:28

Pull request was closed

@spong spong deleted the adds-reverse-nested-tests branch November 9, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants