Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.16] Features integrations + mobile, copy, design tweaks (#115495) #115858

Merged
merged 2 commits into from
Oct 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/core/public/rendering/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@
top: $headerHeight;
}

.kbnStickyMenu {
position: sticky;
max-height: calc(100vh - #{$headerHeight + $euiSize});
top: $headerHeight + $euiSize;
@include euiBreakpoint('xl', 'l') {
.kbnStickyMenu {
position: sticky;
max-height: calc(100vh - #{$headerHeight + $euiSize});
top: $headerHeight + $euiSize;
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const EmptyIndexListPrompt = ({
<EuiCard
className="inpEmptyState__card"
onClick={() => {
navigateToApp('home', { path: '/app/integrations/browse' });
navigateToApp('integrations', { path: '/browse' });
closeFlyout();
}}
icon={<EuiIcon size="xl" type="database" color="subdued" />}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
<EuiCard
paddingSize="l"
image={image}
textAlign="left"
title={
<EuiTextColor color="default">
{i18n.translate('kibana-react.noDataPage.elasticAgentCard.noPermission.title', {
Expand Down Expand Up @@ -92,7 +93,12 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
defaultMessage: `Use Elastic Agent for a simple, unified way to collect data from your machines.`,
})}
betaBadgeLabel={recommended ? NO_DATA_RECOMMENDED : undefined}
footer={footer}
footer={
<div className="eui-textCenter">
{button}
{footer}
</div>
}
layout={layout as 'vertical' | undefined}
{...cardRest}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ export const NoDataCard: FunctionComponent<NoDataPageActions> = ({
return (
<EuiCard
paddingSize="l"
textAlign="left"
// TODO: we should require both title and description to be passed in by consumers since defaults are not adequate.
// see comment: https://github.com/elastic/kibana/pull/111261/files#r708399140
title={title!}
description={i18n.translate('kibana-react.noDataPage.noDataCard.description', {
defaultMessage: `Proceed without collecting data`,
})}
betaBadgeLabel={recommended ? NO_DATA_RECOMMENDED : undefined}
footer={footer}
footer={<div className="eui-textCenter">{footer}</div>}
layout={layout as 'vertical' | undefined}
{...cardRest}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const link = (
const title = (
<FormattedMessage
id="xpack.fleet.epm.integrationPreference.title"
defaultMessage="When an integration is available for {link}, show:"
defaultMessage="If an integration is available for {link}, show:"
values={{ link }}
/>
);
Expand Down Expand Up @@ -115,6 +115,7 @@ export const IntegrationPreference = ({ initialType, onChange }: Props) => {
name="preference"
/>
</EuiForm>
<EuiSpacer size="m" />
</EuiPanel>
);
};
Loading