Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features integrations + mobile, copy, design tweaks #115495

Merged
merged 13 commits into from
Oct 20, 2021
Merged
10 changes: 6 additions & 4 deletions src/core/public/rendering/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@
top: $headerHeight;
}

.kbnStickyMenu {
position: sticky;
max-height: calc(100vh - #{$headerHeight + $euiSize});
top: $headerHeight + $euiSize;
@include euiBreakpoint('xl', 'l') {
.kbnStickyMenu {
position: sticky;
max-height: calc(100vh - #{$headerHeight + $euiSize});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on applying this max-height style regardless if the sticky condition is true? Doing so would avoid the visual "jumpiness" of the menu when transitioning between the non-sticky and sticky modes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a follow up item to track this. I think I have some better ways to do this, but given the FF timing / difficulty around getting stuff merged with tests I'm gonna punt this to a follow PR.

#115696

top: $headerHeight + $euiSize;
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const EmptyIndexListPrompt = ({
<EuiCard
className="inpEmptyState__card"
onClick={() => {
navigateToApp('home', { path: '/app/integrations/browse' });
navigateToApp('integrations', { path: '/browse' });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug from #114911

This fixes the link from the index pattern redirect.

closeFlyout();
}}
icon={<EuiIcon size="xl" type="database" color="subdued" />}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
<EuiCard
paddingSize="l"
image={image}
textAlign="left"
snide marked this conversation as resolved.
Show resolved Hide resolved
title={
<EuiTextColor color="default">
{i18n.translate('kibana-react.noDataPage.elasticAgentCard.noPermission.title', {
Expand Down Expand Up @@ -92,7 +93,12 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
defaultMessage: `Use Elastic Agent for a simple, unified way to collect data from your machines.`,
})}
betaBadgeLabel={recommended ? NO_DATA_RECOMMENDED : undefined}
footer={footer}
footer={
<div className="eui-textCenter">
{button}
{footer}
</div>
}
layout={layout as 'vertical' | undefined}
{...cardRest}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ export const NoDataCard: FunctionComponent<NoDataPageActions> = ({
return (
<EuiCard
paddingSize="l"
textAlign="left"
snide marked this conversation as resolved.
Show resolved Hide resolved
// TODO: we should require both title and description to be passed in by consumers since defaults are not adequate.
// see comment: https://github.com/elastic/kibana/pull/111261/files#r708399140
title={title!}
description={i18n.translate('kibana-react.noDataPage.noDataCard.description', {
defaultMessage: `Proceed without collecting data`,
})}
betaBadgeLabel={recommended ? NO_DATA_RECOMMENDED : undefined}
footer={footer}
footer={<div className="eui-textCenter">{footer}</div>}
layout={layout as 'vertical' | undefined}
{...cardRest}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const link = (
const title = (
<FormattedMessage
id="xpack.fleet.epm.integrationPreference.title"
defaultMessage="When an integration is available for {link}, show:"
defaultMessage="If an integration is available for {link}, show:"
values={{ link }}
/>
);
Expand Down Expand Up @@ -115,6 +115,7 @@ export const IntegrationPreference = ({ initialType, onChange }: Props) => {
name="preference"
/>
</EuiForm>
<EuiSpacer size="m" />
</EuiPanel>
);
};
Loading