Changes rewriteBasePath core config deprecation level to warning
#114566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
v8.0.0
deprecation_warnings
Feature:Configuration
|
@elasticmachine merge upstream |
TinaHeiligers
added
the
Team:Core
TinaHeiligers
commented
Oct 11, 2021
| @@ -16,6 +16,7 @@ const rewriteBasePathDeprecation: ConfigDeprecation = (settings, fromPath, addDe | |||
| 'will expect that all requests start with server.basePath rather than expecting you to rewrite ' + | |||
| 'the requests in your reverse proxy. Set server.rewriteBasePath to false to preserve the ' + | |||
| 'current behavior and silence this warning.', | |||
| level: 'warning', | |||
There was a problem hiding this comment.
Changed the level to warning for this deprecation to help with cleaning up UA. We need to do some research before deciding on an approach for fully handling the deprecation.
TinaHeiligers
requested review from
a team
and removed request for
pgayvallet
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
TinaHeiligers
added
the
release_note:skip
lukeelmers
approved these changes
Oct 12, 2021
pgayvallet
approved these changes
Oct 12, 2021
TinaHeiligers
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 12, 2021
…lastic#114566) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
I'm getting recurring issues with types in the backport PR. I opened new PR directly to 7.x to make the change rather than try to force the backport to work. |
TinaHeiligers
added
backport:skip
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Oct 13, 2021
…lastic#114566) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
artem-shelkovnikov
pushed a commit
to artem-shelkovnikov/kibana
that referenced
this pull request
Oct 20, 2021
…lastic#114566) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #103915
This PR changes the core
rewriteBasePathdeprecation level fromcriticaltowarningas a stop gap until we come to a decision on an approach.I think it's worth getting this change in to 7.16 to help with reducing noise in the Upgrade Assistant.
Unless anyone feels otherwise, the risk seems quite small.
For maintainers