Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Remove fullscreen mode when workpad unmounts #114551

Merged
merged 4 commits into from
Nov 2, 2021
Merged

[Canvas] Remove fullscreen mode when workpad unmounts #114551

merged 4 commits into from
Nov 2, 2021

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Oct 11, 2021

Summary

Closes #93954

This makes sure that when the workpad component unmounts we remove our fullscreen class and set the kibana chrome to being shown.

@crob611 crob611 requested a review from a team as a code owner October 11, 2021 18:45
@crob611 crob611 added Feature:Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@crob611 crob611 added v7.16.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 11, 2021
@crob611
Copy link
Contributor Author

crob611 commented Oct 12, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Nov 1, 2021

@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Nov 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 971.6KB 971.7KB +110.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 added the v8.1.0 label Nov 2, 2021
@crob611 crob611 merged commit 39d79f7 into elastic:main Nov 2, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 2, 2021
@kibanamachine
Remove fullscreen mode when workpad unmounts (elastic#114551)
937bccf 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Nov 2, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 2, 2021
@kibanamachine
Remove fullscreen mode when workpad unmounts (elastic#114551)
ccbb2ba 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Nov 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 2, 2021
@kibanamachine
Remove fullscreen mode when workpad unmounts (#114551) (#117183)
2ebea58 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 2, 2021
@kibanamachine
Remove fullscreen mode when workpad unmounts (#114551) (#117184)
2ae9625 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
@crob611 crob611 mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canvas: Fullscreen mode doesn't exit on history navigation
4 participants
@crob611 @elasticmachine @kibanamachine @poffdeluxe