[Fleet] Remove escaping numeric value in agent template #114123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
kpollich
approved these changes
Oct 14, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
nchaulet
deleted the
fix-112896-agent-template-should-not-escape-string
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #112896
Context
To go from a package policy to the agent policy as it's going to be send to the agent we used YAML handlebar template defined in the package where we inject variables configured by the user, to be able to handle most of the case we have some custom logic on how we populate this template.
Description
We introduced escaping the text variable, if it's a numerical value when we compile the agent template, this seems to be problematic as it does not allow string interpolation.
That PR remove that, for the integration that really need the yaml to be string, I think the best solution will be to use the
!!strkeyword in the agent template.@elastic/integrations I would love to have your thoughts on that as it is a breaking change, from what I know the only integration impacted by that will be
osquerybut they already stopped to use agent template for 7.16.0.