-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CTI ECS 1.11 fields #113404
Update CTI ECS 1.11 fields #113404
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
@elasticmachine merge upstream |
1988946
to
7514ad6
Compare
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was able to confirm that once I check out the PR and create a new alert, there were no investigation time enrichments on it. Once I posted some data to my filebeat index with a matching sha256 hash under the "threat" field, I was able to see the enrichment as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, although I have not tested this e2e as Ece did. There are some cypress failures around the enrichment e2e tests; I haven't verified whether these are legitimate failures or just outdated tests, but let me know if you need help debugging or fixing them!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@@ -56,7 +56,7 @@ | |||
"module": "threatintel", | |||
"category": "threat", | |||
"type": "indicator", | |||
"dataset": "threatintel.abusemalware" | |||
"dataset": "ti_abusech.malware" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this archive was updated; I think that's at least part of the cause of Cypress failures.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
* Update threatintel to threat * Remove CTI mappings * Update CTI_DATASET_KEY_MAP * Update default threat index * Change mapping to dataset * Fix tests * Fix tests * Fix test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security_solution/server/plugin.ts
* Update threatintel to threat * Remove CTI mappings * Update CTI_DATASET_KEY_MAP * Update default threat index * Change mapping to dataset * Fix tests * Fix tests * Fix test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security_solution/server/plugin.ts
* Update threatintel to threat * Remove CTI mappings * Update CTI_DATASET_KEY_MAP * Update default threat index * Change mapping to dataset * Fix tests * Fix tests * Fix test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 1929f88)
Summary
Update CTI ECS 1.11 fields
Reaplcing
threatintel.indicator
withthreat.indicator
.How to test
Check master and check that CTI works with ECS < 1.11
Copy value from
threatintel.indicator.file.hash.sha256
of first hit of you result. (Later refer as ${SHA256_HASH})Create Custom Rule
Index patterns-
test-filebeat
Custom query
* : *
Let's create an event in our
test-filebeat
indexOpen alert, go to
Threat intel
tab and check that it has indicators field inEnriched with Threat Intelligence
section.For example indicator.file.hash.sha256 - ${SHA256_HASH}
image
Let's create Indicator Match Rule
Index patterns -
test-filebeat
Custom query -
*:*
Indicator index patterns -
filebeat-*
Indicator index query
@timestamp >= "now-30d"
Indicator mapping
file.hash.sha256 MATCHES threatintel.indicator.file.hash.sha256
Additional look-back time - 24H (to catch alert from the previous step)
This rule should catch alerts from the previous step. Open alert, go to
Threat intel
tab and check that it has indicators field inThreat Match Detected
section.image
Check out the branch of this PR
test-filebeat
indexYou should see new alert in Indicator math rule, but you shouldn't have any indicators field on
Threat intel
->Threat Match Detected
sectionimage
image
Create filebeat event (update ${YOUR_DATE} and ${SHA256_HASH})
Threat Match Detected
section.image
image
test-filebeat
indexThreat Match Detected
section.Checklist
Delete any items that are not applicable to this PR.
For maintainers