-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements #112768
[Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements #112768
Conversation
…ge online configuration requirements
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
@elasticmachine merge upstream |
What do you think about moving this to a separate sub-page? This section takes up a lot of space now. Interested to hear what @elastic/kibana-docs think as well. |
@elasticmachine merge upstream |
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@ymao1 your suggestion makes sense, but in this case we will get more nested levels of the docs which is worse supported by the new documents system. @gchaps any thoughts on this? Can we have it as it is or a better approach will be a splitting provider specific docs to a subpages? |
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
for now, i would leave the page as is. the hierarchy in the new docs system will be much flatter. we can revisit after we move the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look great! Left one comment about adding some separation between the deprecated config and the new config and there is one screenshot on the email docs page that would be nice to update with a new screenshot showing the service dropdown.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would help if I click Approve :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[role="screenshot"] | ||
image::management/connectors/images/exchange-secrets.png[MS Exchange secrets configuration] | ||
|
||
Add a new client secret, then copy the value and put it to the proper field in the Microsoft Exchange email connector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a screenshot of where this goes in the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a bunch now, probably when the SDH comes :-)
…ge online configuration requirements (elastic#112768) * [Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements * Added images * Added client secrets * fixed test * fixed links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fixed due to comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update email.asciidoc * fixed due to comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…ge online configuration requirements (#112768) (#114170) * [Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements * Added images * Added client secrets * fixed test * fixed links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fixed due to comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update email.asciidoc * fixed due to comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Resolves #111449
This PR is adding documentation for Microsoft Exchange email connector and UI placeholders with help links.
Link for testing docs: https://kibana_112768.docs-preview.app.elstc.co/guide/en/kibana/master/email-action-type.html#exchange
![Screen Shot 2021-09-26 at 7 59 35 PM](https://user-images.githubusercontent.com/55110838/134839329-3d1b4fcd-45e5-4e47-9cd8-bd8927aefdfe.png)
### ChecklistDelete any items that are not applicable to this PR.