-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] New Add Data Page #112142
[Security Solution] New Add Data Page #112142
Conversation
…data_card/elastic_beats_card.tsx
…ta-screen [Security Solution] Fix tests for new data screen and update index check
…to remove add data screen
@elasticmachine merge upstream |
…log/kibana into task/fix-tests-for-add-data-screen
@elasticmachine merge upstream |
…log/kibana into task/fix-tests-for-add-data-screen
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the thorough checks of indicesExist
. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/plugins/kibana_react/public/page_template/page_template.tsx
data-test-subj change lgtm
* [Security Solution] New Add Data Page Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* [Security Solution] New Add Data Page Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
In support of #107682 and pulled out of original PR #108763
Replaces the current OverviewEmpty contents with the
KibanaPageTemplate.noDataConfig
.It also adds logic to the main TemplateWrapper where it checks for
indicesExist
fromuseSourcererScope()
to show the OverviewEmpty page over any other page contents.The links are:
learn more
: https://www.elastic.co/guide/en/security/master/index.htmlAdd Elastic Agent
: /app/integrations/browse?category=securityChecklist
Delete any items that are not applicable to this PR.