Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] New Add Data Page #112142

Merged
merged 52 commits into from
Oct 6, 2021

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Sep 14, 2021

In support of #107682 and pulled out of original PR #108763

Replaces the current OverviewEmpty contents with the KibanaPageTemplate.noDataConfig.

It also adds logic to the main TemplateWrapper where it checks for indicesExist from useSourcererScope() to show the OverviewEmpty page over any other page contents.

The links are:

Screen Shot 2021-08-16 at 17 38 27 PM

Checklist

Delete any items that are not applicable to this PR.

@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

@kevinlog kevinlog changed the title Task/fix tests for add data screen [Security Solution] New Add Data Page Sep 16, 2021
@kevinlog kevinlog marked this pull request as ready for review September 16, 2021 19:49
@kevinlog kevinlog requested review from a team as code owners September 16, 2021 19:49
@kevinlog
Copy link
Contributor Author

kevinlog commented Oct 4, 2021

@elasticmachine merge upstream

@kevinlog
Copy link
Contributor Author

kevinlog commented Oct 5, 2021

@elasticmachine merge upstream

@kevinlog
Copy link
Contributor Author

kevinlog commented Oct 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.3MB 4.3MB -4.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 94.1KB 94.2KB +37.0B
securitySolution 102.2KB 103.9KB +1.7KB
total +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the thorough checks of indicesExist. LGTM!

@kevinlog kevinlog added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 6, 2021
@kevinlog kevinlog enabled auto-merge (squash) October 6, 2021 00:17
@kevinlog kevinlog disabled auto-merge October 6, 2021 01:42
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/plugins/kibana_react/public/page_template/page_template.tsx data-test-subj change lgtm

@kevinlog kevinlog merged commit dc07c06 into elastic:master Oct 6, 2021
@kevinlog kevinlog deleted the task/fix-tests-for-add-data-screen branch October 6, 2021 11:38
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
* [Security Solution] New Add Data Page

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 6, 2021
* [Security Solution] New Add Data Page

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants