[build] Commit generated init scripts

[jbudz]

1. We don't have any version locking on dependent ruby gems other than docs. This could cause accidental inconsistencies.
2. We can make modifications, giving us more freedom to investigate issues like Setting NODE_OPTIONS with Debian/Ubuntu packages #7237, [Packaging] systemd Service Unit Should Create a PID directory #7759, Documentation for configuring --max-old-space-size #9006, systemd restart loop, reported as running with no errors #10895, etc

[jbudz]

I'm closing this one for now, but may come back to it. pleaserun 0.0.28 will help us set environment variables addressing a few of the issues in number 2. Number one can be solved with a gemfile.

[jbudz]

I got back to this and did some digging, reopening for a few reasons.

1. we need to export NODE_OPTIONS in the sysv scripts to make it available to the bin/kibana script
2. pleaserun's sysv service manages /var/run/kibana. We want to modify this to create a folder, and use kibana.yml to use that folder
3. sysv also pipes logs from stdout to /var/log/kibana.log. We want kibana.yml to manage this too.
4. systemd will retry starting infinity times. permissions issues are fairly common, and this can cause a ton of alerts to get fired on monitoring services

This PR doesn't address any of those issues - I'm keeping this separate so we don't lose it on a merge and for future reference.

[tylersmalley]

We were previously using pleaserun to output kibana.plist and kibana.conf. Should those also be included?

Would it be worth it to keep a task around which uses pleaserun to update these files?

[jbudz]

We aren't making use of kibana.conf and .plist so we should be able to remove them.

For the pleaserun task I'd opt for removing it and pull in updates manually if needed, the more we diverge the more off it will be. As an in between how about a followup PR (or commit here and merge without squashing) to bump this to latest before we start adding changes?

[tylersmalley]

You're right, if we intend on diverging from the pleaserun output then there isn't much of a point to including the tasks.

I bumped pleaserun to 0.0.30 and the only changes were to the init script.

diff --git a/tasks/build/services/sysv/etc/init.d/kibana b/tasks/build/services/sysv/etc/init.d/kibana
index 94066b0c07..07cc25a899 100755
--- a/tasks/build/services/sysv/etc/init.d/kibana
+++ b/tasks/build/services/sysv/etc/init.d/kibana
@@ -20,11 +20,26 @@ export PATH

 name=kibana
 program=/usr/share/kibana/bin/kibana
-args=-c\\\ /etc/kibana/kibana.yml
+args=-c\ /etc/kibana/kibana.yml
 pidfile="/var/run/$name.pid"
+user="kibana"
+group="kibana"
+chroot="/"
+chdir="/"
+nice=""

-[ -r /etc/default/$name ] && . /etc/default/$name
-[ -r /etc/sysconfig/$name ] && . /etc/sysconfig/$name
+
+# If this is set to 1, then when `stop` is called, if the process has
+# not exited within a reasonable time, SIGKILL will be sent next.
+# The default behavior is to simply log a message "program stop failed; still running"
+KILL_ON_STOP_TIMEOUT=0
+
+# When loading default and sysconfig files, we use `set -a` to make
+# all variables automatically into environment variables.
+set -a
+[ -r /etc/default/kibana ] && . /etc/default/kibana
+[ -r /etc/sysconfig/kibana ] && . /etc/sysconfig/kibana
+set +a

 [ -z "$nice" ] && nice=0

@@ -40,9 +55,11 @@ emit() {
 start() {

   # Ensure the log directory is setup correctly.
-  [ ! -d "/var/log/kibana/" ] && mkdir "/var/log/kibana/"
-  chown "$user":"$group" "/var/log/kibana/"
-  chmod 755 "/var/log/kibana/"
+  if [ ! -d "/var/log/kibana/" ]; then
+    mkdir "/var/log/kibana/"
+    chown "$user":"$group" "/var/log/kibana/"
+    chmod 755 "/var/log/kibana/"
+  fi


   # Setup any environmental stuff beforehand
@@ -54,7 +71,7 @@ start() {

     cd \"$chdir\"
     exec \"$program\" $args
-  " >> /var/log/kibana/kibana.stdout 2>> /var/log/kibana/kibana.stderr &
+  " >> /var/log/kibana/kibana-stdout.log 2>> /var/log/kibana/kibana-stderr.log &

   # Generate the pidfile from here. If we instead made the forked process
   # generate it there will be a race condition between the pidfile writing

We might as well take advantage of the updates.

Here are the commands I used:

pleaserun --install --no-install-actions --install-prefix tasks/build/services/systemd --overwrite --name kibana --description Kibana --user kibana --group kibana --log-directory /var/log/kibana/ -p systemd -v default /usr/share/kibana/bin/kibana -c /etc/kibana/kibana.yml

pleaserun --install --no-install-actions --install-prefix tasks/build/services/sysv --overwrite --name kibana --description Kibana --user kibana --group kibana --log-directory /var/log/kibana/ -p sysv -v lsb-3.1 /usr/share/kibana/bin/kibana -c /etc/kibana/kibana.yml

[tylersmalley]

LGTM - let's move forward with the version of pleaserun we are on and we can bump in a subsequent PR