Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Assistant] Update copy to use "issues" instead of "warnings" #111817

Merged
merged 3 commits into from
Sep 10, 2021
Merged

[Upgrade Assistant] Update copy to use "issues" instead of "warnings" #111817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a847ba
update copy to use "issues" instead of "warnings"
alisonelizabeth Sep 10, 2021
11e338b
fix message string
alisonelizabeth Sep 10, 2021
8052f36
Merge branch '7.x' into ua/copy_updates
kibanamachine Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../upgrade_assistant/public/application/components/overview/fix_logs_step/fix_logs_step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const i18nTexts = {
defaultMessage: 'Identify deprecated API use and update your applications',
}),
toggleTitle: i18n.translate('xpack.upgradeAssistant.overview.toggleTitle', {
defaultMessage: 'Log Elasticsearch deprecation warnings',
defaultMessage: 'Log Elasticsearch deprecation issues',
}),
analyzeTitle: i18n.translate('xpack.upgradeAssistant.overview.analyzeTitle', {
defaultMessage: 'Analyze deprecation logs',
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/upgrade_assistant/public/application/lib/breadcrumbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ const i18nTexts = {
defaultMessage: 'Upgrade Assistant',
}),
esDeprecations: i18n.translate('xpack.upgradeAssistant.breadcrumb.esDeprecationsLabel', {
defaultMessage: 'Elasticsearch deprecation warnings',
defaultMessage: 'Elasticsearch deprecation issues',
}),
kibanaDeprecations: i18n.translate(
'xpack.upgradeAssistant.breadcrumb.kibanaDeprecationsLabel',
{
defaultMessage: 'Kibana deprecation warnings',
defaultMessage: 'Kibana deprecation issues',
}
),
},
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/upgrade_assistant/server/routes/status.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('Status API', () => {
expect(resp.payload).toEqual({
readyForUpgrade: false,
details:
'You have 1 Elasticsearch deprecation warnings and 1 Kibana deprecation warnings that must be resolved before upgrading.',
'You have 1 Elasticsearch deprecation issue and 1 Kibana deprecation issue that must be resolved before upgrading.',
});
});

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/upgrade_assistant/server/routes/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function registerUpgradeStatusRoute({ router, lib: { handleEsError } }: R

return i18n.translate('xpack.upgradeAssistant.status.deprecationsUnresolvedMessage', {
defaultMessage:
'You have {esTotalCriticalDeps} Elasticsearch deprecation warnings and {kibanaTotalCriticalDeps} Kibana deprecation warnings that must be resolved before upgrading.',
'You have {esTotalCriticalDeps} Elasticsearch deprecation {esTotalCriticalDeps, plural, one {issue} other {issues}} and {kibanaTotalCriticalDeps} Kibana deprecation {kibanaTotalCriticalDeps, plural, one {issue} other {issues}} that must be resolved before upgrading.',
values: { esTotalCriticalDeps, kibanaTotalCriticalDeps },
});
};
Expand Down