Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Remove deprecated maps.manifestServiceUrl configuration #111656

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

nickpeihl
Copy link
Member

@nickpeihl nickpeihl commented Sep 8, 2021

Summary

maps.manifestServiceUrl is an undocumented configuration that was deprecated in 7.6. Originally this setting pointed to an EMS catalogue service, but has been been replaced by the documented map.emsUrl and undocumented map.emsFileApiUrl and map.emsTileApiUrl settings.

Edit: Since this was never a documented API, we can skip the release note as that would probably just cause confusion for the user.

## Release Note
Removed undocumented map.manifestServiceUrl configuration. You must use the map.emsUrl setting in kibana.yml instead to specify the URL of a self hosted Elastic Maps Server instance.

For maintainers

@nickpeihl nickpeihl added release_note:breaking Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 labels Sep 8, 2021
@nickpeihl nickpeihl requested review from a team as code owners September 8, 2021 21:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@pgayvallet
Copy link
Contributor

retest

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core changes.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

@nickpeihl
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 218 217 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 78.2KB 78.1KB -139.0B
Unknown metric groups

API count

id before after diff
maps 219 218 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickpeihl nickpeihl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting and removed release_note:breaking labels Sep 9, 2021
@nickpeihl nickpeihl merged commit 4b60458 into elastic:master Sep 9, 2021
@nickpeihl nickpeihl deleted the rm-manifesturl branch September 9, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants