Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Added loading for certificates page on initial load #111526

Merged
merged 2 commits into from
Sep 8, 2021
Merged

[Uptime] Added loading for certificates page on initial load #111526

merged 2 commits into from
Sep 8, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Fix elastic/uptime#360

Added loading message for certificate page on initial load

@shahzad31 shahzad31 self-assigned this Sep 8, 2021
@shahzad31 shahzad31 added v7.15.0 v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 8, 2021
@shahzad31 shahzad31 marked this pull request as ready for review September 8, 2021 13:02
@shahzad31 shahzad31 requested a review from a team as a code owner September 8, 2021 13:02
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

justinkambic
justinkambic approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checked this with and without certs, all messages seemed good to me.

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 8, 2021
@shahzad31 shahzad31 enabled auto-merge (squash) September 8, 2021 15:50
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.0MB 1.0MB +281.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit 032810e into elastic:master Sep 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
@shahzad31 @kibanamachine
[Uptime] Added loading for certificates page on initial load (elastic…
8af6d53 
…#111526)
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
@shahzad31 @kibanamachine
[Uptime] Added loading for certificates page on initial load (elastic…
d7cfdf0 
…#111526)
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 8, 2021
@kibanamachine @shahzad31
[Uptime] Added loading for certificates page on initial load (#111526) (
2db1a61 
#111604)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request Sep 8, 2021
@kibanamachine @shahzad31
[Uptime] Added loading for certificates page on initial load (#111526) (
ad4317a 
#111603)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
@shahzad31 @chrisronline
[Uptime] Added loading for certificates page on initial load (elastic…
e9c37b6 
…#111526)
@shahzad31 shahzad31 deleted the fix-cert-loading branch September 13, 2021 16:47
@shahzad31 shahzad31 mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Certs loading state UX on page reload
4 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic