Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy dashboards import/export API: deprecation logs and usage data #111283

Merged
merged 11 commits into from
Sep 8, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Sep 6, 2021

Summary

Closes #41439

  • Adds usage data for the legacy dashboard import/export API so that we can check how many users still use this
  • Adds warning log when the API is called

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf changed the title Move legacy dashboards API to core and adds usage data legacy dashboards import/export API: deprecation logs and usage data Sep 6, 2021
@rudolf rudolf marked this pull request as ready for review September 6, 2021 14:59
@rudolf rudolf requested a review from a team as a code owner September 6, 2021 15:00
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +48 to +49
export const LEGACY_DASHBOARDS_IMPORT_STATS_PREFIX = 'apiCalls.legacyDashboardImport';
export const LEGACY_DASHBOARDS_EXPORT_STATS_PREFIX = 'apiCalls.legacyDashboardExport';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be added to ALL_COUNTER_FIELDS?

@rudolf rudolf added release_note:skip Skip the PR/issue when compiling release notes v7.15.1 v7.16.0 labels Sep 7, 2021
@rudolf rudolf added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 7, 2021
@rudolf rudolf enabled auto-merge (squash) September 7, 2021 10:41
@rudolf
Copy link
Contributor Author

rudolf commented Sep 8, 2021

@elasticmachine merge upstream

@rudolf rudolf removed the v7.15.1 label Sep 8, 2021
@rudolf rudolf requested a review from a team as a code owner September 8, 2021 14:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit 5464af6 into elastic:master Sep 8, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 111283

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
…lastic#111283)

* Move legacy dashboards API to core and adds usage data

* More legacy_export plugin removal

* Log a warning for deprecated dashboard import/export API

* Review comments
rudolf added a commit to rudolf/kibana that referenced this pull request Sep 9, 2021
…lastic#111283)

* Move legacy dashboards API to core and adds usage data

* More legacy_export plugin removal

* Log a warning for deprecated dashboard import/export API

* Review comments
# Conflicts:
#	.github/CODEOWNERS
#	docs/developer/plugin-list.asciidoc
#	src/core/server/saved_objects/routes/legacy_import_export/lib/index.ts
rudolf added a commit that referenced this pull request Sep 10, 2021
… data (#111283) (#111710)

* legacy dashboards import/export API: deprecation logs and usage data (#111283)

* Move legacy dashboards API to core and adds usage data

* More legacy_export plugin removal

* Log a warning for deprecated dashboard import/export API

* Review comments
# Conflicts:
#	.github/CODEOWNERS
#	docs/developer/plugin-list.asciidoc
#	src/core/server/saved_objects/routes/legacy_import_export/lib/index.ts

* Fix type errors
@rudolf rudolf deleted the legacy-import-usage branch September 21, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Dashboard Import/Export API
3 participants