Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Timeline uses existing filter manager #111143

Merged
merged 2 commits into from
Sep 7, 2021
Merged

[Security Solution] Timeline uses existing filter manager #111143

merged 2 commits into from
Sep 7, 2021

Conversation

michaelolo24
Copy link
Contributor

@michaelolo24 michaelolo24 commented Sep 3, 2021 •
edited
Loading

Summary

This PR resolves #108165. Filter manager was not being passed when createTimeline was called via useInvestigateInTimeline, leading to the filter in and filter out functionality not working when that function was invoked via the add to timeline button in the actions column of the table.

@michaelolo24 michaelolo24 added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.14.2 labels Sep 3, 2021
@michaelolo24 michaelolo24 changed the title [Security Solution] Use existing filter manager [Security Solution] Timeline uses existing filter manager Sep 3, 2021
@michaelolo24 michaelolo24 marked this pull request as ready for review September 3, 2021 15:36
@michaelolo24 michaelolo24 requested a review from a team as a code owner September 3, 2021 15:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@michaelolo24
Copy link
Contributor Author

@elasticmachine merge upstream

@michaelolo24 michaelolo24 enabled auto-merge (squash) September 7, 2021 02:41
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +907.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@michaelolo24 michaelolo24 merged commit 5bc6239 into elastic:master Sep 7, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 7, 2021
@michaelolo24 @kibanamachine
[Security Solution] Timeline uses existing filter manager (elastic#11…
1e5d944 
…1143)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 7, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 7, 2021
@michaelolo24 @kibanamachine
[Security Solution] Timeline uses existing filter manager (elastic#11…
7fed55a 
…1143)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 7, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

@michaelolo24 michaelolo24 mentioned this pull request Sep 7, 2021
Merged
kibanamachine added a commit that referenced this pull request Sep 7, 2021
@kibanamachine @michaelolo24
[Security Solution] Timeline uses existing filter manager (#111143) (#…
d3319a2 
…111311)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
kibanamachine added a commit that referenced this pull request Sep 7, 2021
@kibanamachine @michaelolo24
[Security Solution] Timeline uses existing filter manager (#111143) (#…
b7014c9 
…111312)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution]Applied Filter on hover in Host detail flyout under timeline not working
4 participants
@michaelolo24 @elasticmachine @kibanamachine @kqualters-elastic