Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout for displaying welcome interstitial for new users #110498

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Increase timeout for displaying welcome interstitial for new users #110498

merged 2 commits into from
Aug 31, 2021

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Aug 30, 2021 •
edited
Loading

Summary

Fixes #107020

This check can take 1-2 seconds in production environments, so the 500ms timeout is often leading to not showing this UI in a critical path for new onboarding users. This PR increases the timeout to 10s for the following reasons:

  • Once a user is shown this UI once, we skip making this query in the first place.
  • The case where an index pattern already exists is much faster, which minimizes the risk of increasing this timeout since this is the typical case for users who are not going to see this UI anyways.
  • At least once in my testing this took 5s

Unless a new BC is cut for 7.14.1, this PR will only affect 7.14.2.

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0 v7.14.2 labels Aug 30, 2021
@joshdover joshdover requested a review from a team as a code owner August 30, 2021 15:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@joshdover joshdover added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 30, 2021
@joshdover joshdover enabled auto-merge (squash) August 30, 2021 15:47
TinaHeiligers
TinaHeiligers approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The risk of such a large increase in the timeout for the welcome interstitial seems low enough to warrant the change.
LGTM

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 257cddd into elastic:master Aug 31, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 31, 2021
@joshdover @kibanamachine
Increase timeout for displaying welcome interstitial for new users (e…
4789574 
…lastic#110498)
@kibanamachine kibanamachine mentioned this pull request Aug 31, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.15 Commit could not be cherrypicked due to conflicts
✅ 7.x
❌ 7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 110498

kibanamachine added a commit that referenced this pull request Aug 31, 2021
@kibanamachine @joshdover
Increase timeout for displaying welcome interstitial for new users (#…
588de6a 
…110498) (#110653)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
joshdover added a commit to joshdover/kibana that referenced this pull request Sep 1, 2021
@joshdover
Increase timeout for displaying welcome interstitial for new users (e…
3351b5d 
…lastic#110498)
@joshdover joshdover mentioned this pull request Sep 1, 2021
Merged
joshdover added a commit to joshdover/kibana that referenced this pull request Sep 1, 2021
@joshdover
Increase timeout for displaying welcome interstitial for new users (e…
bdf5c4c 
…lastic#110498)

# Conflicts:
#	src/plugins/home/public/application/components/home.tsx
@joshdover joshdover mentioned this pull request Sep 1, 2021
Merged
joshdover added a commit that referenced this pull request Sep 1, 2021
@joshdover
Increase timeout for displaying welcome interstitial for new users (#…
55fed60 
…110498) (#110783)

# Conflicts:
#	src/plugins/home/public/application/components/home.tsx
joshdover added a commit that referenced this pull request Sep 1, 2021
@joshdover
Increase timeout for displaying welcome interstitial for new users (#…
2108e3b 
…110498) (#110781)
@joshdover joshdover mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.2 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Add Data welcome / interstitial page
4 participants
@joshdover @elasticmachine @kibanamachine @TinaHeiligers