Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix colours in the Anomaly swim lane and Annotations chart #110001

Merged
merged 2 commits into from
Aug 25, 2021
Merged

[ML] Fix colours in the Anomaly swim lane and Annotations chart #110001

merged 2 commits into from
Aug 25, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Aug 25, 2021 •
edited
Loading

Summary

Checklist

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 25, 2021
@darnautov darnautov self-assigned this Aug 25, 2021
@darnautov darnautov requested a review from a team as a code owner August 25, 2021 07:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed y axis label selection fixed. LGTM

@darnautov darnautov merged commit 53283c5 into elastic:master Aug 25, 2021
@darnautov darnautov deleted the ml-swim-lane-fixes branch August 25, 2021 11:28
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@darnautov @kibanamachine
[ML] Fix colours in the Anomaly swim lane and Annotations chart (elas…
ea30565 
…tic#110001)

* [ML] use current theme

* [ML] use current theme in annotations chart
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@darnautov @kibanamachine
[ML] Fix colours in the Anomaly swim lane and Annotations chart (elas…
97b04e8 
…tic#110001)

* [ML] use current theme

* [ML] use current theme in annotations chart
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.1MB 6.1MB +312.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @darnautov
[ML] Fix colours in the Anomaly swim lane and Annotations chart (#110001
872745b 
) (#110033)

* [ML] use current theme

* [ML] use current theme in annotations chart

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @darnautov
[ML] Fix colours in the Anomaly swim lane and Annotations chart (#110001
a5a96ab 
) (#110034)

* [ML] use current theme

* [ML] use current theme in annotations chart

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darnautov @elasticmachine @kibanamachine @peteharverson