Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index pattern field editor] index patterns => data views for user facing content #109704

Merged
merged 2 commits into from
Aug 24, 2021
Merged

[index pattern field editor] index patterns => data views for user facing content #109704

merged 2 commits into from
Aug 24, 2021

Conversation

mattkime
Copy link
Contributor

Summary

'Index pattern' => 'Data view' for user facing copy in index pattern field editor.

@mattkime mattkime requested a review from a team as a code owner August 23, 2021 17:29
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.0.0 Team:AppServices labels Aug 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime mentioned this pull request Aug 23, 2021
Closed
22 tasks
@mattkime mattkime changed the title index patterns => data views [index pattern field editor] index patterns => data views for user facing content Aug 23, 2021
tsullivan
tsullivan reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment which will hopefully achieve a more natural tone. Otherwise LGTM

@mattkime @tsullivan
Update src/plugins/index_pattern_field_editor/public/open_editor.tsx
9e11461 
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 1601ba8 into elastic:index_patterns_to_data_views_user_content_feature_branch Aug 24, 2021
@mattkime mattkime mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan left review comments

Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattkime @elasticmachine @kibanamachine @tsullivan