Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index pattern editor] index pattern to data view for user facing content #109578

Merged
merged 5 commits into from
Aug 24, 2021
Merged

[index pattern editor] index pattern to data view for user facing content #109578

merged 5 commits into from
Aug 24, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Aug 22, 2021 •
edited
Loading

Summary

'Index pattern' => 'Data view' for user facing copy - index pattern editor plugin

@mattkime mattkime changed the title index pattern to data view for user facing content [index pattern editor] index pattern to data view for user facing content Aug 22, 2021
@mattkime mattkime mentioned this pull request Aug 22, 2021
Closed
22 tasks
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v8.0.0 labels Aug 22, 2021
@mattkime mattkime marked this pull request as ready for review August 23, 2021 03:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime requested a review from a team as a code owner August 23, 2021 03:56
tsullivan
tsullivan reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion about tuning the rollup_beta_warning text to have a more natural tone. Otherwise LGTM

@mattkime @tsullivan
Update src/plugins/index_pattern_editor/public/components/rollup_beta…
c40a2ed 
…_warning/rollup_beta_warning.tsx

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 2220a35 into elastic:index_patterns_to_data_views_user_content_feature_branch Aug 24, 2021
@mattkime mattkime mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan left review comments

Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattkime @elasticmachine @kibanamachine @tsullivan