Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler #109442

Merged

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 20, 2021

One step forward on #69706

That PR moves the @kbn/securitysolution-t-grid from using tsc compiler to babel transpiler to produce the js outputs.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v7.14.1 labels Aug 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@FrankHassanabad
Copy link
Contributor

Question:
I compared package.json it to the others and it does look to have one additional property they do not here:
https://github.com/elastic/kibana/blob/master/packages/kbn-securitysolution-t-grid/package.json#L6

"browser": "./target_web/browser.js",

Is that needed/wanted? If so, what is that for?

@mistic
Copy link
Member Author

mistic commented Aug 20, 2021

@FrankHassanabad that is needed in case the pkg is to be required on browser bundles 😄

@FrankHassanabad
Copy link
Contributor

@mistic,

With regards to:
https://github.com/elastic/kibana/blob/master/packages/kbn-securitysolution-t-grid/package.json#L6

something feels off though as it is trying to point to the file ./target_web/browser.js but I don't see that file anywhere in the source directory or in the output directory.

cd node_modules/@kbn/securitysolution-t-grid/target_web
ls 
drwxr-xr-x  4 frankhassanabad  wheel   128B Aug 19 12:00 constants
-r-xr-xr-x  1 frankhassanabad  wheel   465B Aug 19 12:00 index.js
-r-xr-xr-x  1 frankhassanabad  wheel   227B Aug 19 12:00 index.js.map
drwxr-xr-x  6 frankhassanabad  wheel   192B Aug 19 12:00 mock
drwxr-xr-x  6 frankhassanabad  wheel   192B Aug 19 12:00 utils

Should it really be this?

"browser": "./target_web/index.js",

I think they copied from i18n package.json but that actually does have a browser.ts where this has a index.ts file.

@mistic
Copy link
Member Author

mistic commented Aug 20, 2021

@FrankHassanabad I see, good catch. Changed and pushed! Thanks

Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • Looked over this PR and compared it to similar ones and the directory structures to see if anything was overlooked

@mistic
Copy link
Member Author

mistic commented Aug 22, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB -8.7KB
timelines 437.2KB 436.8KB -320.0B
total -9.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 317.9KB 307.2KB -10.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 9a3e8ef into elastic:master Aug 23, 2021
mistic added a commit to mistic/kibana that referenced this pull request Aug 23, 2021
…lastic#109442)

* chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler

* chore(NA): fix package.json

* chore(NA): finetunning package

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-securitysolution-t-grid/BUILD.bazel
#	packages/kbn-securitysolution-t-grid/tsconfig.browser.json
#	packages/kbn-securitysolution-t-grid/tsconfig.json
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
…lastic#109442)

* chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler

* chore(NA): fix package.json

* chore(NA): finetunning package

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
…lastic#109442)

* chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler

* chore(NA): fix package.json

* chore(NA): finetunning package

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.15
7.x
7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 109442

mistic added a commit that referenced this pull request Aug 23, 2021
…109442) (#109675)

* chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler

* chore(NA): fix package.json

* chore(NA): finetunning package

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-securitysolution-t-grid/BUILD.bazel
#	packages/kbn-securitysolution-t-grid/tsconfig.browser.json
#	packages/kbn-securitysolution-t-grid/tsconfig.json
kibanamachine added a commit that referenced this pull request Aug 23, 2021
…109442) (#109676)

* chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler

* chore(NA): fix package.json

* chore(NA): finetunning package

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
kibanamachine added a commit that referenced this pull request Aug 23, 2021
…109442) (#109677)

* chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler

* chore(NA): fix package.json

* chore(NA): finetunning package

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.1 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants