-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Updated product_selector
to match new No Data screens
#108592
[Enterprise Search] Updated product_selector
to match new No Data screens
#108592
Conversation
…creens Pulled work out of original PR elastic#107709
Hey Enterprise Search team, sorry for the double-review. I've pulled this out of the other PR so it wouldn't get prolonged by the updates from the other solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Wahoo! Changes look great and super clean! I think @daveyholler or @johnbarrierwilson has to approve as well, but this should be good to go code wise!
Thank you both!! 💟 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HUZZAH!
Argh, sorry about that failing test Caroline. Definitely a good lesson in not hooking our test assertions into CSS classes (vs. You should be able to fix it by replacing this line: with expect(mockContainer.querySelector('.kbnPageTemplate')).not.toBeNull(); |
No worries. Thanks for the tip @constancecchen . I'll be sure to run the test locally too. |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
…creens (elastic#108592) And updated product selector images to match new Kibana UI
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
@daveyholler, @scottybollinger Here are a few suggestions for the UI copy Change intro sentence? Instead of "Choose a product to set up and get started", which I think users can figure out, how about doing this instead:
Then you would have just 1 line here:
suggest "our videos because it is friendlier Add a comma after experiences
|
|
Looks good to me. Small typo SMAL -> SAML |
Good catch. Updated the text. |
Pulled work out of original PR #107709
Mainly visual changes to the overview product selector screen which now uses KibanaPageTemplate directly.
And updated the product images to match the new UI.
Checklist