Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Updated product_selector to match new No Data screens #108592

Merged
merged 4 commits into from
Aug 14, 2021

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Aug 13, 2021

Pulled work out of original PR #107709

Mainly visual changes to the overview product selector screen which now uses KibanaPageTemplate directly.

And updated the product images to match the new UI.

Screen Shot 2021-08-13 at 16 21 52 PM

Screen Shot 2021-08-13 at 15 38 11 PM

Screen Shot 2021-08-13 at 16 22 28 PM

Checklist

@cchaos cchaos requested a review from cee-chen August 13, 2021 19:44
@cchaos cchaos requested a review from a team as a code owner August 13, 2021 19:44
@cchaos cchaos requested a review from a team August 13, 2021 19:44
@cchaos cchaos added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 labels Aug 13, 2021
@cchaos
Copy link
Contributor Author

cchaos commented Aug 13, 2021

Hey Enterprise Search team, sorry for the double-review. I've pulled this out of the other PR so it wouldn't get prolonged by the updates from the other solutions.

Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Wahoo! Changes look great and super clean! I think @daveyholler or @johnbarrierwilson has to approve as well, but this should be good to go code wise!

@cchaos
Copy link
Contributor Author

cchaos commented Aug 13, 2021

Thank you both!! 💟

Copy link
Contributor

@daveyholler daveyholler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUZZAH!

@cchaos cchaos enabled auto-merge (squash) August 13, 2021 20:33
@cee-chen
Copy link
Member

Argh, sorry about that failing test Caroline. Definitely a good lesson in not hooking our test assertions into CSS classes (vs. data-test-subj) 🙈 🤦‍♀️

You should be able to fix it by replacing this line:

https://github.com/elastic/kibana/blob/master/x-pack/plugins/enterprise_search/public/applications/index.test.tsx#L67

with

      expect(mockContainer.querySelector('.kbnPageTemplate')).not.toBeNull();

@cchaos
Copy link
Contributor Author

cchaos commented Aug 13, 2021

No worries. Thanks for the tip @constancecchen . I'll be sure to run the test locally too.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1482 1472 -10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.1MB -19.3KB
Unknown metric groups

miscellaneous assets size

id before after diff
enterpriseSearch 886.8KB 1.0MB +142.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cchaos cchaos merged commit e33cdc2 into elastic:master Aug 14, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 14, 2021
…creens (elastic#108592)

And updated product selector images to match new Kibana UI
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 14, 2021
…creens (#108592) (#108618)

And updated product selector images to match new Kibana UI

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@cchaos cchaos deleted the ent_search/product_selector_updates branch August 14, 2021 15:52
@gchaps
Copy link
Contributor

gchaps commented Aug 16, 2021

@daveyholler, @scottybollinger Here are a few suggestions for the UI copy

Change intro sentence?

Instead of "Choose a product to set up and get started", which I think users can figure out, how about doing this instead:

Welcome to Elastic Enterprise Search
Add search to your app or organization with Elastic App Search and Workplace Search.

Then you would have just 1 line here:

Enterprise-grade features
Watch our videos to see what you can do when search is made easy.

suggest "our videos because it is friendlier

Add a comma after experiences

Enterprise-grade features
Enterprise authentication via SAML, document-level permission and authorization support, custom search experiences**,** and more with a Platinum license.

@scottybollinger
Copy link
Contributor

@daveyholler, @scottybollinger Here are a few suggestions for the UI copy

Change intro sentence?

Instead of "Choose a product to set up and get started", which I think users can figure out, how about doing this instead:

Welcome to Elastic Enterprise Search
Add search to your app or organization with Elastic App Search and Workplace Search.

Then you would have just 1 line here:

Enterprise-grade features
Watch our videos to see what you can do when search is made easy.

suggest "our videos because it is friendlier

Add a comma after experiences

Enterprise-grade features
Enterprise authentication via SMAL, document-level permission and authorization support, custom search experiences**,** and more with a Platinum license.

@jonasll @zumwalt @aznick thoughts?

@jonasll
Copy link

jonasll commented Aug 16, 2021

Looks good to me.

Small typo SMAL -> SAML

@gchaps
Copy link
Contributor

gchaps commented Aug 16, 2021

Good catch. Updated the text.

@cchaos cchaos mentioned this pull request Aug 17, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants