Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Link to Add Data (Beats tutorials) when there are no integrations found #108224

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

jen-huang
Copy link
Contributor

Summary

Relates to #107682. This PR adds a link to Add Data tutorials directory when there are no integrations found from the user's query, in addition to the existing link for a custom input:

image

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.14.1 labels Aug 11, 2021
@jen-huang jen-huang self-assigned this Aug 11, 2021
@jen-huang jen-huang requested a review from a team as a code owner August 11, 2021 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@@ -201,7 +205,7 @@ function MissingIntegrationContent({
<p>
<FormattedMessage
id="xpack.fleet.integrations.missing"
defaultMessage="Don't see an integration? Collect any logs or metrics using our {customInputsLink}. Request new integrations using our {discussForumLink}."
defaultMessage="Don't see an integration? Collect any logs or metrics using our {customInputsLink}, or set up {beatsTutorialLink}. Request new integrations using our {discussForumLink}."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mostlyjason @VijayDoshi Thoughts on this copy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "or add data using Beats modules"? We haven't told the user about agent or beats yet, so they might not understand the significance of calling them "individual" Beats here.

@mostlyjason
Copy link
Contributor

@jen-huang what do you think about changing the title of this page to "Elastic Agent Integrations"? That would make it more clear how this page differs from our add data tutorials. Once we make it a unified integrations page, we can change it back to just "Integrations". That might be too long for the sidebar menu, but there is space in the page content?

We could also update the subtitle to say "Collect data from popular apps and services using Elastic Agent".

@jen-huang jen-huang removed their assignment Aug 12, 2021
@kpollich kpollich self-assigned this Aug 12, 2021
@kpollich
Copy link
Member

@mostlyjason - I've made the copy updates you requested above here.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 717.2KB 717.6KB +488.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

Copy link
Contributor Author

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

😄 Consider this comment my approval. Thanks for taking it over @kpollich!

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kpollich kpollich merged commit 7fb30ba into elastic:master Aug 13, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 13, 2021
…ions found (elastic#108224)

* Link to add data/beats tutorials when there are no integrations found

* Address PR feedback + fox i18n

* Update integrations page subtitle

Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 13, 2021
…ions found (elastic#108224)

* Link to add data/beats tutorials when there are no integrations found

* Address PR feedback + fox i18n

* Update integrations page subtitle

Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x
7.14

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 13, 2021
…ions found (#108224) (#108520)

* Link to add data/beats tutorials when there are no integrations found

* Address PR feedback + fox i18n

* Update integrations page subtitle

Co-authored-by: Kyle Pollich <kpollich1@gmail.com>

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
kibanamachine added a commit that referenced this pull request Aug 13, 2021
…ions found (#108224) (#108519)

* Link to add data/beats tutorials when there are no integrations found

* Address PR feedback + fox i18n

* Update integrations page subtitle

Co-authored-by: Kyle Pollich <kpollich1@gmail.com>

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
@jen-huang jen-huang deleted the fix/add-data-link branch August 16, 2021 18:24
@ghost
Copy link

ghost commented Aug 24, 2021

Hi @jen-huang

We have gone through the ticket and Created 02 new test-Cases and Updated 01 test-Cases.
Moreover we have one Enhancement related to ticket. So Could you please provide your inputs on the Same.


Test-Case Creation :

  • Created 02 Test-Cases
Test-Case Link Title Remark
C149951 Validate the Title displayed under 'Integration tab' -
C149952 Validate 'Beats module' link is available on page when no searched integration is available on integrations tab. -

Test-Case Updation:

  • Updated 01 Test-Case with Current Functionality
Test-Case Link Title
C15433 Validate the description displayed under ‘Integrations’ tab

Enhancement : "Installed Elastic Agent integrations" should displayed instead of "Installed integrations" under Integrations->Manage tab for better visibility for user.
Manage

Thanks!!

@jen-huang
Copy link
Contributor Author

@vipulsrivastava-qasource Thank you for the suggestion, but I think expanding the title there would be too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants