-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use kbnArchiver and test_user with minimal role in x-pack/test/functional/apps/rollup_job/tsvb.js #107712
Conversation
Pinging @elastic/kibana-security (Team:Security) |
Pinging @elastic/kibana-operations (Team:Operations) |
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 CLA has been signed |
@elasticmachine merge upstream |
…t uses minimal set of roles-permissions for the test-user lint errors lint errors
cc0ac0d
to
2207166
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - only code reviewed and Jenkins results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only, LGTM!
await kibanaServer.uiSettings.replace({ | ||
defaultIndex: 'rollup', | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, is this actually needed? It looks like you load a config object from rollup.json
that already sets the default index to "rollup".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jportner I just had a discussion with @wayneseymour about this for another test he's working on. I don't really understand why, but the "config" object we load from an archive never seems to be used. After this kbnArchive is loaded, if you look at the saved objects, you'll find another one for the current version and it won't have the defaultIndex set. I don't know if it's only because the version doesn't match, or if Kibana already created another one? It could be because we don't treat the previous version config object like an upgrade case on dev builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, interesting! Not sure why but it's good to know for future reference!
closing this in favor of #107818 - all the changes are incorporated in the new PPR linked with additional changes) |
part of [meta] Migrate .kibana esArchives to kbnArchiver #102552
part of Use test_user with minimum privileges for functional ui tests under rollup_job folder #84970
Migrate esArchiver to use kbnArchiver for the
tsvb rollup_job test
Conversion of superuser to
test_user
with minimum privileges for functional tsvb test