Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use kbnArchiver and test_user with minimal role in x-pack/test/functional/apps/rollup_job/tsvb.js #107712

Closed
wants to merge 1 commit into from

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni added Team:Operations Team label for Operations Team Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! test_xpack_functional Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 5, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Aug 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 5, 2021

💚 CLA has been signed

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

…t uses minimal set of roles-permissions for the test-user

lint errors

lint errors
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #143136 succeeded 7545e7855ca3f4eaec85a63c66ff8cb711d656e8
  • 💔 Build #143131 failed 8f9d5402092a10493c65f9f6f02896cd5f058039

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

@LeeDr LeeDr changed the title Updated the test to use kbnArchiver to load the data and also the test user uses the minimal set of roles-permissions to perform the test functionality use kbnArchiver and test_user with minimal role in x-pack/test/functional/apps/rollup_job/tsvb.js Aug 5, 2021
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only code reviewed and Jenkins results.

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM!

Comment on lines +43 to +45
await kibanaServer.uiSettings.replace({
defaultIndex: 'rollup',
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, is this actually needed? It looks like you load a config object from rollup.json that already sets the default index to "rollup".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jportner I just had a discussion with @wayneseymour about this for another test he's working on. I don't really understand why, but the "config" object we load from an archive never seems to be used. After this kbnArchive is loaded, if you look at the saved objects, you'll find another one for the current version and it won't have the defaultIndex set. I don't know if it's only because the version doesn't match, or if Kibana already created another one? It could be because we don't treat the previous version config object like an upgrade case on dev builds?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting! Not sure why but it's good to know for future reference!

@rashmivkulkarni
Copy link
Contributor Author

closing this in favor of #107818 - all the changes are incorporated in the new PPR linked with additional changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:Visualizations Visualization editors, elastic-charts and infrastructure test_xpack_functional v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants