Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Added visual indicator when enable switched click is processed on the server side. #107272

Conversation

YulNaumenko
Copy link
Contributor

Summary

New behavior: when the user click on the Enabled switch, loading spinner will be displayed till the server return the response

Screen.Recording.2021-07-30.at.12.38.23.PM.mov

Resolves #106276

@YulNaumenko YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0 Feature:Alerting/RulesManagement Issues related to the Rules Management UX labels Jul 30, 2021
@YulNaumenko YulNaumenko requested a review from a team as a code owner July 30, 2021 10:06
@YulNaumenko YulNaumenko self-assigned this Jul 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I am unable to rapidly enable/disable anymore :)

Do you think we can do the same thing for the enable/disable switch on the rule details page? If that's a bigger fix feel free to make a separate issue.

Also can we add unit tests for this?

@YulNaumenko YulNaumenko requested a review from ymao1 August 3, 2021 21:46
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 360 361 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +2.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko merged commit 30f68dd into elastic:master Aug 4, 2021
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Aug 4, 2021
…ocessed on the server side. (elastic#107272)

* [Alerting UI] Added visual indicator when enable switched click is processed on the server side.

* fixed rule details

* fixed functional tests

* fixed unit tests

* fixed due to comments

* fixed due to comments
YulNaumenko added a commit that referenced this pull request Aug 4, 2021
…ocessed on the server side. (#107272) (#107703)

* [Alerting UI] Added visual indicator when enable switched click is processed on the server side.

* fixed rule details

* fixed functional tests

* fixed unit tests

* fixed due to comments

* fixed due to comments
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
…ocessed on the server side. (elastic#107272)

* [Alerting UI] Added visual indicator when enable switched click is processed on the server side.

* fixed rule details

* fixed functional tests

* fixed unit tests

* fixed due to comments

* fixed due to comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alerting UI] Add visual indicator of the next request delay between rules enable/disable switch clicking.
4 participants