-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting UI] Added visual indicator when enable switched click is processed on the server side. #107272
[Alerting UI] Added visual indicator when enable switched click is processed on the server side. #107272
Conversation
…ocessed on the server side.
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I am unable to rapidly enable/disable anymore :)
Do you think we can do the same thing for the enable/disable switch on the rule details page? If that's a bigger fix feel free to make a separate issue.
Also can we add unit tests for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works as expected.
...iggers_actions_ui/public/application/sections/alerts_list/components/rule_enabled_switch.tsx
Outdated
Show resolved
Hide resolved
...iggers_actions_ui/public/application/sections/alert_details/components/rule_muted_switch.tsx
Outdated
Show resolved
Hide resolved
...iggers_actions_ui/public/application/sections/alert_details/components/rule_muted_switch.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
…ocessed on the server side. (elastic#107272) * [Alerting UI] Added visual indicator when enable switched click is processed on the server side. * fixed rule details * fixed functional tests * fixed unit tests * fixed due to comments * fixed due to comments
…ocessed on the server side. (elastic#107272) * [Alerting UI] Added visual indicator when enable switched click is processed on the server side. * fixed rule details * fixed functional tests * fixed unit tests * fixed due to comments * fixed due to comments
Summary
New behavior: when the user click on the Enabled switch, loading spinner will be displayed till the server return the response
Screen.Recording.2021-07-30.at.12.38.23.PM.mov
Resolves #106276