Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unused @babel/plugin-transform-modules-commonjs dependency #107250

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Removes unused @babel/plugin-transform-modules-commonjs dependency #107250

merged 3 commits into from
Aug 4, 2021

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Jul 29, 2021 •
edited
Loading

This dependency was mostly removed in #66506, but still used by @kbn/interpreter. #101089 removed the usage of this plugin so it can now be removed.

Removes unused @babel/plugin-transform-modules-commonjs dependency
32e5bf6 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley tylersmalley marked this pull request as ready for review August 2, 2021 21:08
@tylersmalley tylersmalley added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.15.0 v8.0.0 labels Aug 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley tylersmalley enabled auto-merge (squash) August 4, 2021 20:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit ee6ffc0 into elastic:master Aug 4, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 4, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2021
@kibanamachine
Removes unused @babel/plugin-transform-modules-commonjs dependency (e…
359e0c0 
…lastic#107250)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 5, 2021
@kibanamachine
Removes unused @babel/plugin-transform-modules-commonjs dependency (#…
54f986c 
…107250) (#107707)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@kibanamachine @vadimkibana
Removes unused @babel/plugin-transform-modules-commonjs dependency (e…
35ece13 
…lastic#107250)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylersmalley @elasticmachine @kibanamachine @jbudz