[Enterprise Search] Added the InlineEditableTable component #107208
Conversation
JasonStoltz
added
auto-backport
| // TODO This could likely be a selector | ||
| isEditing: boolean; | ||
| // TODO we should editingItemValue have editingItemValue and editingItemId should be a selector |
There was a problem hiding this comment.
Just to check, I'm seeing 7 TODO type comments in the full diff - were they left in intentionally for a future PR or did you want to address them before merge?
There was a problem hiding this comment.
I left them in as something we could do later at some point. Not critical though. I'm not doing them in this PR in any case, so if you'd prefer I'm happy to just remove them.
There was a problem hiding this comment.
Nope, I think they serve well as future TODOs!
There was a problem hiding this comment.
I still need to QA this but it looks good. There are a bunch of todos as @constancecchen pointed out, is the plan to address those in a future PR for GenericEndpointInlineEditableTable or as tech debt down the road?
| /> | ||
| ); | ||
| const bindLogic = wrapper.find(BindLogic); | ||
| expect(bindLogic.props()).toEqual( |
| >; | ||
|
|
||
| export const InlineEditableTableLogic = kea<InlineEditableTableLogicType<ItemWithAnID>>({ | ||
| path: (key: string) => ['enterprise_search', 'inline_editable_table_logic', key], |
There was a problem hiding this comment.
I remember losing so much time before realizing I had to use a function for the path
There was a problem hiding this comment.
I remember Byron swooping in like an eagle and solving this for me! 🎉
| import { Column } from '../reorderable_table/types'; | ||
|
|
||
| export interface FormErrors { | ||
| [key: string]: string | undefined; |
There was a problem hiding this comment.
I wonder if this needs the | undefined. This should be equivalent to
export interface FormErrors {
[key: string]: string;
}
I think?
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
This is a component required by the Crawler view. It is a wrapper around the ReorderableTable component. It adds CRUD operations for the items in the table.
This commit history in this PR is NOT very coherent. This PR unfortunately will likely need to be reviewed as one big diff.
While this is mostly a port from the component of the same name from
ent-search, there are a few key changes that I made along the way:Itemacted as the unique "id" field of that item. I dropped that and instead we are requiring that all items used with this component have an "id" field. This was for simplicity.BindLogicso that we can use the logic in sub-components without having to pass through the key (and other props) down through the component tree.To get an idea of what all of the scenarios that this component can be used for, please check out both the unit tests and the component library.
Checklist
Delete any items that are not applicable to this PR.
For maintainers