Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Removing legacy es client from alerting test #107152

Merged
merged 2 commits into from
Aug 2, 2021
Merged

[Alerting] Removing legacy es client from alerting test #107152

merged 2 commits into from
Aug 2, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jul 29, 2021

Summary

One more usage of the legacy es client in integration tests snuck in.

@ymao1 ymao1 self-assigned this Jul 29, 2021
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0 v8.0.0 labels Jul 29, 2021
@ymao1 ymao1 marked this pull request as ready for review July 29, 2021 12:39
@ymao1 ymao1 requested a review from a team as a code owner July 29, 2021 12:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 mentioned this pull request Jul 29, 2021
Closed
74 tasks
YulNaumenko
YulNaumenko reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Aug 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 2, 2021
@ymao1 ymao1 merged commit 1334622 into elastic:master Aug 2, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 2, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2021
@ymao1 @kibanamachine
Removing legacy es client from alerting test (elastic#107152)
ac3dce0 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 2, 2021
@kibanamachine @ymao1
Removing legacy es client from alerting test (#107152) (#107460)
51edc2b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@ymao1 @kibanamachine @vadimkibana
Removing legacy es client from alerting test (elastic#107152)
c414b80 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ymao1 ymao1 deleted the alerting/legacy-es-test branch August 17, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@ymao1 ymao1

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymao1 @elasticmachine @kibanamachine @YulNaumenko