Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Update ES archive for tests #106837

Merged
merged 9 commits into from
Jul 27, 2021
Merged

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Jul 27, 2021

Updates ES archive. Had to make some changes where things were hardcoded or to accommodate API changes in es-archiver, and disable SO v2 migration because it tried to migrate things whilst es archiver was deleting and re-creating kibana indices, causing tests to fail.

Update: see #106846

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.15.0 labels Jul 27, 2021
@dgieselaar dgieselaar marked this pull request as ready for review July 27, 2021 11:28
@dgieselaar dgieselaar requested a review from a team as a code owner July 27, 2021 11:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 27, 2021
@dgieselaar dgieselaar enabled auto-merge (squash) July 27, 2021 11:28
@@ -307,42 +307,6 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
});

describe('when not defined environments is seleted', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the edge cluster does not have any services without the environment being defined.

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
actions - 117 +117
advancedSettings - 22 +22
alerting - 234 +234
apm - 39 +39
apmOss - 4 +4
banners - 9 +9
bfetch - 62 +62
canvas - 5 +5
cases - 407 +407
charts - 159 +159
cloud - 21 +21
core - 1081 +1081
dashboard - 137 +137
dashboardEnhanced - 50 +50
dashboardMode - 11 +11
data - 3162 +3162
dataEnhanced - 16 +16
dataVisualizer - 104 +104
devTools - 8 +8
discover - 55 +55
discoverEnhanced - 37 +37
embeddable - 384 +384
embeddableEnhanced - 14 +14
encryptedSavedObjects - 28 +28
enterpriseSearch - 2 +2
esUiShared - 90 +90
eventLog - 70 +70
expressionError - 12 +12
expressionImage - 4 +4
expressionMetric - 4 +4
expressionRepeatImage - 28 +28
expressionRevealImage - 4 +4
expressions - 1569 +1569
expressionShape - 90 +90
features - 97 +97
fileUpload - 128 +128
fleet - 1033 +1033
globalSearch - 14 +14
home - 70 +70
indexLifecycleManagement - 4 +4
indexManagement - 157 +157
indexPatternFieldEditor - 29 +29
infra - 22 +22
inspector - 78 +78
kibanaLegacy - 62 +62
kibanaReact - 230 +230
kibanaUtils - 359 +359
lens - 191 +191
licenseApiGuard - 8 +8
licenseManagement - 3 +3
licensing - 42 +42
lists - 143 +143
management - 40 +40
maps - 203 +203
mapsEms - 75 +75
metricsEntities - 6 +6
ml - 274 +274
monitoring - 10 +10
navigation - 31 +31
newsfeed - 17 +17
observability - 219 +219
osquery - 11 +11
presentationUtil - 149 +149
remoteClusters - 4 +4
reporting - 132 +132
rollup - 20 +20
ruleRegistry - 60 +60
runtimeFields - 19 +19
savedObjects - 199 +199
savedObjectsManagement - 85 +85
savedObjectsTagging - 50 +50
savedObjectsTaggingOss - 50 +50
screenshotMode - 17 +17
security - 51 +51
securityOss - 9 +9
securitySolution - 1245 +1245
share - 83 +83
snapshotRestore - 22 +22
spacesOss - 5 +5
stackAlerts - 4 +4
taskManager - 25 +25
telemetryCollectionManager - 29 +29
telemetryCollectionXpack - 1 +1
telemetryManagementSection - 13 +13
timelines - 763 +763
triggersActionsUi - 228 +228
uiActions - 88 +88
uiActionsEnhanced - 147 +147
urlForwarding - 15 +15
usageCollection - 16 +16
visTypeTimeseries - 10 +10
visualizations - 229 +229
total +15363

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
bfetch - 1 +1
charts - 2 +2
core - 148 +148
dashboard - 1 +1
data - 98 +98
dataVisualizer - 3 +3
embeddable - 4 +4
esUiShared - 4 +4
expressions - 58 +58
fileUpload - 4 +4
fleet - 15 +15
indexManagement - 12 +12
indexPatternFieldEditor - 1 +1
inspector - 6 +6
kibanaLegacy - 3 +3
kibanaReact - 5 +5
kibanaUtils - 3 +3
maps - 2 +2
mapsEms - 1 +1
ml - 10 +10
presentationUtil - 3 +3
reporting - 1 +1
savedObjects - 3 +3
savedObjectsTaggingOss - 3 +3
securitySolution - 8 +8
share - 1 +1
snapshotRestore - 1 +1
timelines - 6 +6
triggersActionsUi - 1 +1
uiActionsEnhanced - 2 +2
visTypeTimeseries - 1 +1
visualizations - 13 +13
total +424

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
actions - 7 +7
advancedSettings - 1 +1
alerting - 16 +16
apm - 30 +30
bfetch - 2 +2
canvas - 3 +3
cases - 14 +14
charts - 1 +1
core - 31 +31
dashboard - 9 +9
data - 64 +64
dataEnhanced - 2 +2
devTools - 2 +2
discover - 6 +6
discoverEnhanced - 2 +2
embeddable - 3 +3
encryptedSavedObjects - 3 +3
esUiShared - 1 +1
eventLog - 4 +4
expressionError - 2 +2
expressionImage - 1 +1
expressionMetric - 1 +1
expressionRevealImage - 1 +1
expressions - 5 +5
features - 2 +2
fileUpload - 1 +1
fleet - 8 +8
globalSearch - 5 +5
home - 5 +5
indexManagement - 3 +3
indexPatternFieldEditor - 4 +4
infra - 3 +3
inspector - 4 +4
kibanaLegacy - 1 +1
kibanaReact - 4 +4
kibanaUtils - 8 +8
lens - 23 +23
licensing - 8 +8
lists - 38 +38
management - 5 +5
maps - 11 +11
metricsEntities - 1 +1
ml - 33 +33
monitoring - 2 +2
navigation - 2 +2
observability - 10 +10
presentationUtil - 5 +5
reporting - 14 +14
ruleRegistry - 9 +9
runtimeFields - 2 +2
savedObjects - 5 +5
screenshotMode - 1 +1
security - 6 +6
securityOss - 3 +3
securitySolution - 28 +28
share - 8 +8
snapshotRestore - 1 +1
taskManager - 8 +8
telemetryCollectionManager - 4 +4
timelines - 25 +25
triggersActionsUi - 19 +19
uiActions - 11 +11
uiActionsEnhanced - 10 +10
usageCollection - 2 +2
visTypeTimeseries - 3 +3
visualizations - 12 +12
total +568
Unknown metric groups

API count

id before after diff
actions - 117 +117
advancedSettings - 23 +23
alerting - 242 +242
apm - 39 +39
apmOss - 4 +4
banners - 9 +9
bfetch - 73 +73
canvas - 6 +6
cases - 445 +445
charts - 190 +190
cloud - 21 +21
core - 2360 +2360
dashboard - 160 +160
dashboardEnhanced - 51 +51
dashboardMode - 11 +11
data - 3716 +3716
dataEnhanced - 16 +16
dataVisualizer - 104 +104
devTools - 10 +10
discover - 81 +81
discoverEnhanced - 39 +39
embeddable - 456 +456
embeddableEnhanced - 14 +14
encryptedSavedObjects - 30 +30
enterpriseSearch - 2 +2
esUiShared - 92 +92
eventLog - 70 +70
expressionError - 12 +12
expressionImage - 4 +4
expressionMetric - 4 +4
expressionRepeatImage - 28 +28
expressionRevealImage - 4 +4
expressions - 2003 +2003
expressionShape - 90 +90
features - 215 +215
fileUpload - 128 +128
fleet - 1128 +1128
globalSearch - 68 +68
home - 94 +94
indexLifecycleManagement - 4 +4
indexManagement - 162 +162
indexPatternFieldEditor - 31 +31
infra - 25 +25
inspector - 101 +101
kibanaLegacy - 66 +66
kibanaReact - 260 +260
kibanaUtils - 551 +551
lens - 207 +207
licenseApiGuard - 8 +8
licenseManagement - 3 +3
licensing - 117 +117
lists - 150 +150
management - 40 +40
maps - 204 +204
mapsEms - 75 +75
metricsEntities - 9 +9
ml - 278 +278
monitoring - 10 +10
navigation - 31 +31
newsfeed - 17 +17
observability - 219 +219
osquery - 11 +11
presentationUtil - 176 +176
remoteClusters - 4 +4
reporting - 133 +133
rollup - 20 +20
ruleRegistry - 60 +60
runtimeFields - 24 +24
savedObjects - 213 +213
savedObjectsManagement - 96 +96
savedObjectsTagging - 54 +54
savedObjectsTaggingOss - 89 +89
screenshotMode - 22 +22
security - 112 +112
securityOss - 12 +12
securitySolution - 1296 +1296
share - 123 +123
snapshotRestore - 23 +23
spaces - 106 +106
spacesOss - 72 +72
stackAlerts - 4 +4
taskManager - 52 +52
telemetry - 42 +42
telemetryCollectionManager - 29 +29
telemetryCollectionXpack - 1 +1
telemetryManagementSection - 14 +14
timelines - 882 +882
triggersActionsUi - 237 +237
uiActions - 127 +127
uiActionsEnhanced - 205 +205
urlForwarding - 15 +15
usageCollection - 57 +57
visTypeTimeseries - 10 +10
visualizations - 247 +247
total +19295

References to deprecated APIs

id before after diff
actions - 8 +8
alerting - 32 +32
apm - 7 +7
canvas - 51 +51
cases - 151 +151
crossClusterReplication - 2 +2
dashboard - 128 +128
dashboardEnhanced - 10 +10
dataEnhanced - 53 +53
dataVisualizer - 16 +16
discover - 102 +102
discoverEnhanced - 19 +19
embeddable - 2 +2
encryptedSavedObjects - 2 +2
fleet - 89 +89
globalSearch - 4 +4
graph - 2 +2
indexLifecycleManagement - 2 +2
indexManagement - 12 +12
infra - 292 +292
lens - 160 +160
lists - 9 +9
maps - 592 +592
ml - 140 +140
observability - 34 +34
presentationUtil - 2 +2
savedObjects - 6 +6
savedObjectsManagement - 18 +18
savedObjectsTaggingOss - 5 +5
security - 2 +2
securitySolution - 800 +800
stackAlerts - 104 +104
timelines - 76 +76
transform - 16 +16
uptime - 11 +11
urlDrilldown - 18 +18
visTypeTimeseries - 12 +12
visualizations - 32 +32
total +3021

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 0d5d453 into elastic:master Jul 27, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 106837

@dgieselaar dgieselaar deleted the update-archive branch July 27, 2021 18:30
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 29, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 106837 or prevent reminders by adding the backport:skip label.

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jul 30, 2021
# Conflicts:
#	x-pack/test/apm_api_integration/tests/transactions/distribution.ts
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 106837 or prevent reminders by adding the backport:skip label.

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Aug 3, 2021
dgieselaar added a commit that referenced this pull request Aug 3, 2021
@dgieselaar dgieselaar added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 3, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 3, 2021
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants