Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] server.basePath vs server.rewriteBasePath #106798

Merged
merged 2 commits into from
Jul 27, 2021
Merged

[DOC] server.basePath vs server.rewriteBasePath #106798

merged 2 commits into from
Jul 27, 2021

Conversation

stefnestor
Copy link
Contributor

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

currently says about server.rewriteBasePath

image

vs 6.8 originally said about server.basePath

image

which makes more sense because server.rewriteBasePath is boolean

@stefnestor
server.basePath vs server.rewriteBasePath
51a7e82 
Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

gchaps
gchaps approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM with a few minor comments.

docs/developer/advanced/development-basepath.asciidoc Outdated Show resolved Hide resolved
docs/developer/advanced/development-basepath.asciidoc Outdated Show resolved Hide resolved
@gchaps gchaps added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0 labels Jul 26, 2021
@stefnestor @gchaps
Apply suggestions from code review
c1fec5e 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps merged commit f66bf62 into master Jul 27, 2021
@gchaps gchaps deleted the sn_serverBasePaths branch July 27, 2021 19:48
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 27, 2021
@stefnestor @gchaps
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
7a5b145 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Jul 27, 2021
Merged
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 27, 2021
@stefnestor @gchaps
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
3bda1b9 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Jul 27, 2021
Merged
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 27, 2021
@stefnestor @gchaps
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
726088c 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Jul 27, 2021
Merged
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 27, 2021
@stefnestor @gchaps
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
2449f35 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Jul 27, 2021
Merged
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 27, 2021
@stefnestor @gchaps
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
2c2c87d 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Jul 27, 2021
Merged
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 27, 2021
@stefnestor @gchaps
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
dc7b5fd 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Jul 27, 2021
Merged
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 27, 2021
@stefnestor @gchaps
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
fafa23a 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Jul 27, 2021
Merged
gchaps added a commit that referenced this pull request Jul 27, 2021
@gchaps @stefnestor
[DOC] server.basePath vs server.rewriteBasePath (#106798) (#106906)
3f8df2e 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Stef Nestor <steffanie.nestor@gmail.com>
gchaps added a commit that referenced this pull request Jul 27, 2021
@gchaps @stefnestor
[DOC] server.basePath vs server.rewriteBasePath (#106798) (#106908)
5d5161a 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Stef Nestor <steffanie.nestor@gmail.com>
gchaps added a commit that referenced this pull request Jul 27, 2021
@gchaps @stefnestor
[DOC] server.basePath vs server.rewriteBasePath (#106798) (#106907)
2628e51 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Stef Nestor <steffanie.nestor@gmail.com>
gchaps added a commit that referenced this pull request Jul 27, 2021
@gchaps @stefnestor
[DOC] server.basePath vs server.rewriteBasePath (#106798) (#106909)
1c9b150 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Stef Nestor <steffanie.nestor@gmail.com>
gchaps added a commit that referenced this pull request Jul 27, 2021
@gchaps @stefnestor
[DOC] server.basePath vs server.rewriteBasePath (#106798) (#106911)
33cfb46 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Stef Nestor <steffanie.nestor@gmail.com>
gchaps added a commit that referenced this pull request Jul 27, 2021
@gchaps @stefnestor
[DOC] server.basePath vs server.rewriteBasePath (#106798) (#106912)
59f7fb2 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Stef Nestor <steffanie.nestor@gmail.com>
gchaps added a commit that referenced this pull request Jul 27, 2021
@gchaps @stefnestor
[DOC] server.basePath vs server.rewriteBasePath (#106798) (#106913)
bba537a 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Stef Nestor <steffanie.nestor@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@stefnestor @gchaps @vadimkibana
[DOC] server.basePath vs server.rewriteBasePath (elastic#106798)
0a57df7 
* server.basePath vs server.rewriteBasePath

Moving content to make pronoun commentary applicable to correct nouns. Lined up to https://www.elastic.co/guide/en/kibana/6.8/settings.html

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@gchaps gchaps gchaps approved these changes

@stacey-gammon stacey-gammon Awaiting requested review from stacey-gammon

Assignees
No one assigned
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.10.0 v7.11.0 v7.12.0 v7.13.0 v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefnestor @elasticmachine @spalger @gchaps