Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out empty values for exceptions #106685

Conversation

academo
Copy link
Contributor

@academo academo commented Jul 26, 2021

Summary

Fixes an issue introduced in #102196 where an exception field form can show an empty value when the endpoint doesn't have a value for an exceptionable field.

This PR will remove from the exception list any empty-valued field for memory protection alerts (shellcode and signature)

This same function will later be used for behavior exceptions.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@academo academo marked this pull request as ready for review July 26, 2021 11:22
@academo academo requested a review from a team as a code owner July 26, 2021 11:22
@academo academo added auto-backport Deprecated - use backport:version if exact versions are needed release_note:feature Makes this part of the condensed release notes v7.15.0 v8.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Jul 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@academo academo requested review from a team, joeypoon and parkiino and removed request for a team July 28, 2021 09:10
@academo academo removed the request for review from parkiino August 2, 2021 07:35
@academo academo added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:feature Makes this part of the condensed release notes labels Aug 2, 2021
@academo academo enabled auto-merge (squash) August 2, 2021 07:36
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.4MB 6.4MB +407.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@academo academo merged commit ee04f6d into elastic:master Aug 2, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 4, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

academo added a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2021
kibanamachine added a commit that referenced this pull request Aug 4, 2021
Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 4, 2021
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants