-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualize] Client Side caching #105589
[Visualize] Client Side caching #105589
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
@alexwizp I am changing the label to feature. I think it is important to mention it on our documentation |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine Alex, thank you a ton!
In case of green CI please merge ❤️
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @alexwizp |
* [Visualize] Client Side caching Closes: elastic#102622 * apply caching for returning to originatingApp * fix case with 'save as' functiionality Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Visualize] Client Side caching Closes: #102622 * apply caching for returning to originatingApp * fix case with 'save as' functiionality Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes: #102622
Summary
Describe the feature:
We could do some optimizations in order for our visualizations to cache the data in the browser and only fetch them when is necessary. Even if I change something that affects the chart and not the data (for example change the palette), a search request runs again.
We could use the session id in order to cache our search requests and only trigger them when is necessary.
Moreover, we could improve our performance if the searchSessionId from the dashboard is shared to the visualization that is edited. In that case, there is no need to re-fetch the data, as they were already fetched on the Dashboard.