View edit mode 4 #10446
Closed
View edit mode 4 #10446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to refresh defaults on a successful save so reset worked as expected.
stacey-gammon
force-pushed
the
view-edit-mode-4
branch
from
1a0510e
to
ac8b018
Compare
stacey-gammon
force-pushed
the
view-edit-mode-4
branch
3 times, most recently
from
f462c03
to
c4b3d2d
Compare
|
@stacey-gammon does the clone functionality work here? I hit clone and it seems to overwrite the original dashboard with the new title. Regardless of if I rename it or not.
I just realized how small and terrible that GIF is, please let me know if you'd prefer a quick screen share :-) |
and issue with filter comparison ($state was different - globalState vs appState)
stacey-gammon
force-pushed
the
view-edit-mode-4
branch
from
c4b3d2d
to
6867e98
Compare
|
@alexfrancoeur It was a bug, should be fixed now. Let me know if you run into any more issues! |
|
@stacey-gammon LGTM. I'll schedule some usability tests for today and tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly different top nav config than Iteration #3