Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isFetchingItems flag to disable the PromptForItems when fetching items in Visualize and Dashboard listing tables. #10381

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Add isFetchingItems flag to disable the PromptForItems when fetching items in Visualize and Dashboard listing tables. #10381

merged 1 commit into from
Feb 16, 2017

Conversation

cjcenizal
Copy link
Contributor

Partially addresses #10283

When searching the table, when you type a query that matches nothing, then delete it to match something... there's a flicker where for a split second we show the "Looks like you don’t have any dashboards. Let’s create some!" message (the animated gif bellow is only managed to capture it once... but it effectively happens all the time)

The same flickering happens when switching back and forth between Visualize & Dashboard

dashboard-search

@cjcenizal
Add isFetchingItems flag to disable the PromptForItems when fetching …
d2483ad 
…items in Visualize and Dashboard listing tables.
@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. bug Fixes for quality problems that affect the customer experience v5.3.0 v5.4.0 v6.0.0 labels Feb 15, 2017
@epixa
Copy link
Contributor

epixa commented Feb 16, 2017

LGTM

@cjcenizal cjcenizal merged commit f002e5d into elastic:master Feb 16, 2017
@cjcenizal cjcenizal deleted the bug/visualize-dashboard-landing-table-flicker branch February 16, 2017 16:13
elastic-jasper added a commit that referenced this pull request Feb 16, 2017
@elastic-jasper
Add isFetchingItems flag to disable the PromptForItems when fetching …
ae7e4f8 
…items in Visualize and Dashboard listing tables.

Backports PR #10381

**Commit 1:**
Add isFetchingItems flag to disable the PromptForItems when fetching items in Visualize and Dashboard listing tables.

* Original sha: d2483ad
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T21:19:30Z
@elastic-jasper elastic-jasper mentioned this pull request Feb 16, 2017
Merged
cjcenizal pushed a commit that referenced this pull request Feb 16, 2017
@elastic-jasper @cjcenizal
Add isFetchingItems flag to disable the PromptForItems when fetching …
041a544 
…items in Visualize and Dashboard listing tables. (#10396)

Backports PR #10381

**Commit 1:**
Add isFetchingItems flag to disable the PromptForItems when fetching items in Visualize and Dashboard listing tables.

* Original sha: d2483ad
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T21:19:30Z
elastic-jasper added a commit that referenced this pull request Feb 16, 2017
@elastic-jasper
Add isFetchingItems flag to disable the PromptForItems when fetching …
152b0b2 
…items in Visualize and Dashboard listing tables.

Backports PR #10381

**Commit 1:**
Add isFetchingItems flag to disable the PromptForItems when fetching items in Visualize and Dashboard listing tables.

* Original sha: d2483ad
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T21:19:30Z
@elastic-jasper elastic-jasper mentioned this pull request Feb 16, 2017
Merged
cjcenizal pushed a commit that referenced this pull request Feb 16, 2017
@elastic-jasper @cjcenizal
Add isFetchingItems flag to disable the PromptForItems when fetching …
30dd0f7 
…items in Visualize and Dashboard listing tables. (#10397)

Backports PR #10381

**Commit 1:**
Add isFetchingItems flag to disable the PromptForItems when fetching items in Visualize and Dashboard listing tables.

* Original sha: d2483ad
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T21:19:30Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.3.0 v5.4.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @epixa