[ML] Fix APM latency order of sticky header properties, add help popover #103759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
:ml
apm:correlations
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine run elasticsearch-ci/docs |
sorenlouv
reviewed
Jun 30, 2021
x-pack/plugins/apm/public/components/app/help_popover/help_popover.scss
Outdated
Show resolved
Hide resolved
qn895
changed the title
stevedodson
reviewed
Jul 5, 2021
x-pack/plugins/apm/public/components/app/correlations/ml_latency_correlations_help_popover.tsx
Outdated
Show resolved
Hide resolved
stevedodson
reviewed
Jul 5, 2021
x-pack/plugins/apm/public/components/app/correlations/ml_latency_correlations_help_popover.tsx
Outdated
Show resolved
Hide resolved
qn895
approved these changes
Jul 6, 2021
|
@elasticmachine merge upstream |
stevedodson
reviewed
Jul 9, 2021
x-pack/plugins/apm/public/components/app/correlations/ml_latency_correlations.tsx
Outdated
Show resolved
Hide resolved
stevedodson
reviewed
Jul 9, 2021
x-pack/plugins/apm/public/components/app/correlations/ml_latency_correlations_help_popover.tsx
Show resolved
Hide resolved
peteharverson
requested changes
Jul 9, 2021
x-pack/plugins/apm/public/components/app/help_popover/help_popover.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @qn895 |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Jul 13, 2021
…ver (elastic#103759) * [ML] APM latency correlations help popover * Remove spacer * [ML] Updates correlation tooltip * Remove scss, use styled popover instead * Fix order to be Service > Environment > Transaction * Addresses popover text feedback * Addresses more popover text feedback * Adds performance warning to popover; improves tooltip * Internationalizes aria label in popover * Internationalizes aria label in ML popover Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Jul 13, 2021
…ver (elastic#103759) * [ML] APM latency correlations help popover * Remove spacer * [ML] Updates correlation tooltip * Remove scss, use styled popover instead * Fix order to be Service > Environment > Transaction * Addresses popover text feedback * Addresses more popover text feedback * Adds performance warning to popover; improves tooltip * Internationalizes aria label in popover * Internationalizes aria label in ML popover Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lcawl
added a commit
that referenced
this pull request
Jul 13, 2021
…ver (#103759) (#105474) * [ML] APM latency correlations help popover * Remove spacer * [ML] Updates correlation tooltip * Remove scss, use styled popover instead * Fix order to be Service > Environment > Transaction * Addresses popover text feedback * Addresses more popover text feedback * Adds performance warning to popover; improves tooltip * Internationalizes aria label in popover * Internationalizes aria label in ML popover Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lcawl
added a commit
that referenced
this pull request
Jul 13, 2021
…ver (#103759) (#105473) * [ML] APM latency correlations help popover * Remove spacer * [ML] Updates correlation tooltip * Remove scss, use styled popover instead * Fix order to be Service > Environment > Transaction * Addresses popover text feedback * Addresses more popover text feedback * Adds performance warning to popover; improves tooltip * Internationalizes aria label in popover * Internationalizes aria label in ML popover Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #99905
This PR fixes #104185. The updated order for the flyout header properties is now Service name | Environment | Transaction name
This PR adds an EuiPopover similar to how they were added in Lens and contains content similar to what was originally written in the Kibana guide.
It also addresses feedback about the text in the tooltip: