Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. #10369

cjcenizal · 2017-02-15T16:50:58Z

Partially addresses #10283

the "Add" button in the table doesn't behave as the "Delete" does button when clicked. According to the UI framework guildelines.. buttons need to move one pixel down when click (as a "clicked feedback")... the Delete button does this, the "Add" button doesn't. Also, the "hover" style is different between the two - The "Delete" button changes bg color to a darker one, the "Add" button seems to change the ("+") text color to a darker one.

…on active and hover states from taking effect.

epixa · 2017-02-16T14:15:02Z

LGTM

…on active and hover states from taking effect. Backports PR #10369 **Commit 1:** Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. * Original sha: 920ef6c * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z

…on active and hover states from taking effect. (#10398) Backports PR #10369 **Commit 1:** Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. * Original sha: 920ef6c * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z

…on active and hover states from taking effect. Backports PR #10369 **Commit 1:** Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. * Original sha: 920ef6c * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z

…on active and hover states from taking effect. (#10399) Backports PR #10369 **Commit 1:** Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. * Original sha: 920ef6c * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z

Fix Safari bug: Safari ignores :enabled pseudo class, preventing butt…

920ef6c

…on active and hover states from taking effect.

cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. bug Fixes for quality problems that affect the customer experience v5.3.0 v5.4.0 v6.0.0 labels Feb 15, 2017

cjcenizal requested a review from stacey-gammon February 16, 2017 01:04

stacey-gammon approved these changes Feb 16, 2017

View reviewed changes

cjcenizal merged commit 408a2e6 into elastic:master Feb 16, 2017

cjcenizal deleted the bug/safari-button-states branch February 16, 2017 16:16

elastic-jasper mentioned this pull request Feb 16, 2017

[5.x] Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. #10398

Merged

elastic-jasper mentioned this pull request Feb 16, 2017

[5.3] Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. #10399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. #10369

Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. #10369

cjcenizal commented Feb 15, 2017 •

edited

Loading

epixa commented Feb 16, 2017

Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. #10369

Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect. #10369

Conversation

cjcenizal commented Feb 15, 2017 • edited Loading

epixa commented Feb 16, 2017

cjcenizal commented Feb 15, 2017 •

edited

Loading